Bug 153869

Summary: Removed unused Settings::setPrivateBrowsingEnabled.
Product: WebKit Reporter: Konstantin Tokarev <annulen>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, kling, mhock
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Konstantin Tokarev
Reported 2016-02-04 08:43:57 PST
Implementation of Settings::setPrivateBrowsingEnabled was removed in r166661, but declaration is still here.
Attachments
Patch (2.18 KB, patch)
2016-02-04 08:49 PST, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
Patch (1.93 KB, patch)
2016-02-04 10:29 PST, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Konstantin Tokarev
Comment 1 2016-02-04 08:49:54 PST
Created attachment 270659 [details] Patch
WebKit Commit Bot
Comment 2 2016-02-04 09:39:36 PST
Comment on attachment 270659 [details] Patch Rejecting attachment 270659 [details] from review queue. annulen@yandex.ru does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights.
WebKit Commit Bot
Comment 3 2016-02-04 09:40:13 PST
Comment on attachment 270659 [details] Patch Rejecting attachment 270659 [details] from commit-queue. annulen@yandex.ru does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
Konstantin Tokarev
Comment 4 2016-02-04 09:46:14 PST
Comment on attachment 270659 [details] Patch Sorry, I've really meant to set flags to '?'.
Alexey Proskuryakov
Comment 5 2016-02-04 10:15:02 PST
Comment on attachment 270659 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=270659&action=review > Source/WebCore/ChangeLog:18 > + * page/Settings.h: > + (WebCore::Settings::dnsPrefetchingEnabled): Deleted. > + (WebCore::Settings::userStyleSheetLocation): Deleted. > + (WebCore::Settings::needsAcrobatFrameReloadingQuirk): Deleted. > + (WebCore::Settings::minimumDOMTimerInterval): Deleted. > + (WebCore::Settings::domTimerAlignmentInterval): Deleted. This is not accurate, please fix the ChangeLog.
Konstantin Tokarev
Comment 6 2016-02-04 10:29:21 PST
Created attachment 270664 [details] Patch
Konstantin Tokarev
Comment 7 2016-02-04 10:30:21 PST
Comment on attachment 270659 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=270659&action=review >> Source/WebCore/ChangeLog:18 >> + (WebCore::Settings::domTimerAlignmentInterval): Deleted. > > This is not accurate, please fix the ChangeLog. Looks like prepare-ChangeLog should be the next target of my perl exercises :)
WebKit Commit Bot
Comment 8 2016-02-04 11:20:51 PST
Comment on attachment 270664 [details] Patch Clearing flags on attachment: 270664 Committed r196134: <http://trac.webkit.org/changeset/196134>
WebKit Commit Bot
Comment 9 2016-02-04 11:20:56 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.