| Summary: | ArrayPrototype should have a destroy function | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Keith Miller <keith_miller> | ||||||
| Component: | New Bugs | Assignee: | Keith Miller <keith_miller> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, mark.lam, msaboff, saam | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Keith Miller
2016-02-03 17:08:11 PST
Created attachment 270612 [details]
Patch
Comment on attachment 270612 [details]
Patch
destroy() will not be called unless you also add
static const bool needsDestruction = true;
to ArrayPrototype.
(This will cause it to get allocated in a MarkedBlock that runs destructors.)
Created attachment 270697 [details]
Patch
Comment on attachment 270697 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=270697&action=review > Source/JavaScriptCore/jsc.cpp:2092 > + vm->heap.collectAllGarbage(); why not tear down the VM here? Per an offline conversation with Filip, users don't usually do it and a we want jsc.cpp to act in a way that models how people the framework. I wouldn't be opposed to adding another option doing so in a different patch, however. Comment on attachment 270697 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=270697&action=review >> Source/JavaScriptCore/jsc.cpp:2092 >> + vm->heap.collectAllGarbage(); > > why not tear down the VM here? VM tear-down would test other things that maybe we don't want to test with gcAtEnd. Comment on attachment 270697 [details] Patch Clearing flags on attachment: 270697 Committed r196155: <http://trac.webkit.org/changeset/196155> All reviewed patches have been landed. Closing bug. |