Bug 153842

Summary: git-add-reviewer should work when run from a subdirectory within the repository
Product: WebKit Reporter: BJ Burg <bburg>
Component: Tools / TestsAssignee: BJ Burg <bburg>
Severity: Normal CC: bburg, commit-queue, dbates, ddkilzer, joepeck, lforschler
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch ddkilzer: review+

Description BJ Burg 2016-02-03 13:23:35 PST
There is a very old FIXME i'm about to delete.
Comment 1 BJ Burg 2016-02-03 13:32:03 PST
Created attachment 270598 [details]
Comment 2 David Kilzer (:ddkilzer) 2016-02-03 13:46:59 PST
Comment on attachment 270598 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=270598&action=review


> Tools/ChangeLog:14
> +        fix this same issue for prepare-Changelogs.

Nit:  Capitalization of prepare-ChangeLogs.

> Tools/Scripts/git-add-reviewer:89
> +my $gitDirectory = gitDirectory();

I tend to dislike adding globals (when you could just call gitDirectory() at each place it's needed), but I don't feel strongly enough to r- this.
Comment 3 BJ Burg 2016-02-03 16:35:37 PST
Committed r196097: <http://trac.webkit.org/changeset/196097>