Summary: | git-add-reviewer should work when run from a subdirectory within the repository | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | BJ Burg <bburg> | ||||
Component: | Tools / Tests | Assignee: | BJ Burg <bburg> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bburg, commit-queue, dbates, ddkilzer, joepeck, lforschler | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
BJ Burg
2016-02-03 13:23:35 PST
Created attachment 270598 [details]
Patch
Comment on attachment 270598 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=270598&action=review r=me > Tools/ChangeLog:14 > + fix this same issue for prepare-Changelogs. Nit: Capitalization of prepare-ChangeLogs. > Tools/Scripts/git-add-reviewer:89 > +my $gitDirectory = gitDirectory(); I tend to dislike adding globals (when you could just call gitDirectory() at each place it's needed), but I don't feel strongly enough to r- this. Committed r196097: <http://trac.webkit.org/changeset/196097> |