Bug 153833

Summary: Timeouts in tests because of non implemented UIScriptController::singleTapAtPoint()
Product: WebKit Reporter: Adrien Plazas <aplazas>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, lforschler, mcatanzaro, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Skip tests using UIScriptController in WebKitGTK+.
simon.fraser: commit-queue-
Skip tests using UIScriptController in WebKitGTK+. none

Adrien Plazas
Reported 2016-02-03 09:35:41 PST
Test fast/events/can-click-element-on-page-with-active-pseudo-class-and-search-field.html times out in GTK Linux 64-bit Debug (Tests) because UIScriptController::singleTapAtPoint() isn't implemented. Lots of other methods of UIScriptController are not implemented and may be causing other tests to fail.
Attachments
Skip tests using UIScriptController in WebKitGTK+. (1.56 KB, patch)
2016-02-04 02:24 PST, Adrien Plazas 		simon.fraser: commit-queue-
DetailsFormatted DiffDiff
Skip tests using UIScriptController in WebKitGTK+. (1.42 KB, patch)
2016-02-08 00:40 PST, Adrien Plazas 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2016-02-03 15:10:24 PST
Tests using UIScriptController stuff to generate events should all be skipped on non-iOS platforms.
Adrien Plazas
Comment 2 2016-02-04 02:24:29 PST
Created attachment 270647 [details] Skip tests using UIScriptController in WebKitGTK+.
Simon Fraser (smfr)
Comment 3 2016-02-05 02:20:45 PST
Comment on attachment 270647 [details] Skip tests using UIScriptController in WebKitGTK+. View in context: https://bugs.webkit.org/attachment.cgi?id=270647&action=review > LayoutTests/platform/gtk/TestExpectations:1505 > +webkit.org/b/153833 fast/harness/concurrent-ui-side-scripts.html [ Skip ] > +webkit.org/b/153833 fast/harness/ui-side-scripts.html [ Skip ] You should not skip these two. They test that UIScriptController is working.
Michael Catanzaro
Comment 4 2016-02-05 10:39:21 PST
The expectations should go under 2. EXPECTED FAILURES
Adrien Plazas
Comment 5 2016-02-08 00:40:16 PST
Created attachment 270847 [details] Skip tests using UIScriptController in WebKitGTK+.
WebKit Commit Bot
Comment 6 2016-02-08 05:43:13 PST
Comment on attachment 270847 [details] Skip tests using UIScriptController in WebKitGTK+. Clearing flags on attachment: 270847 Committed r196250: <http://trac.webkit.org/changeset/196250>
WebKit Commit Bot
Comment 7 2016-02-08 05:43:17 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.