Bug 153827

Summary: [Tools] Remove $additionalCMakeArgs variable because without this variable --cmakeargs options works well
Product: WebKit Reporter: Joonghun Park <jh718.park>
Component: Tools / TestsAssignee: Joonghun Park <jh718.park>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, annulen, commit-queue, dbates, gyuyoung.kim, lforschler, mcatanzaro, ossy
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Joonghun Park
Reported 2016-02-03 03:05:43 PST
When an array is passed to subroutines as argument in perl, a list containing its element is returned from the array. Currently @$ arguments are being passed, then it is going to be one list including all the elements not only from @ but also from $. As a result, $additionalCMakeArgs in sub generateBuildSystemFromCMakeProject is not being used.
Attachments
Patch (1.71 KB, patch)
2016-02-03 04:25 PST, Joonghun Park 		no flags
DetailsFormatted DiffDiff
Patch (2.14 KB, patch)
2016-02-03 05:01 PST, Joonghun Park 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Joonghun Park
Comment 1 2016-02-03 04:25:22 PST
Created attachment 270569 [details] Patch
Konstantin Tokarev
Comment 2 2016-02-03 04:39:13 PST
I saw this bug but I decided that nobody needs $additionalCMakeArgs.
Joonghun Park
Comment 3 2016-02-03 04:41:20 PST
(In reply to comment #2) > I saw this bug but I decided that nobody needs $additionalCMakeArgs. If the variable doesn't needed anymore, then maybe is it ok to be removed instead?
Konstantin Tokarev
Comment 4 2016-02-03 04:44:28 PST
Looks like --cmakeargs works fine with this issue present, so it seems to be a good idea to remove dead code.
Joonghun Park
Comment 5 2016-02-03 04:50:36 PST
(In reply to comment #4) > Looks like --cmakeargs works fine with this issue present, so it seems to be > a good idea to remove dead code. All right, then I'm gonna remove this thing immediately.
Joonghun Park
Comment 6 2016-02-03 05:01:59 PST
Created attachment 270571 [details] Patch
Konstantin Tokarev
Comment 7 2016-02-03 05:37:49 PST
LGTM.
WebKit Commit Bot
Comment 8 2016-02-03 15:06:56 PST
Comment on attachment 270571 [details] Patch Clearing flags on attachment: 270571 Committed r196085: <http://trac.webkit.org/changeset/196085>
WebKit Commit Bot
Comment 9 2016-02-03 15:07:01 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.