Summary: | [Tools] Remove $additionalCMakeArgs variable because without this variable --cmakeargs options works well | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joonghun Park <jh718.park> | ||||||
Component: | Tools / Tests | Assignee: | Joonghun Park <jh718.park> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | achristensen, annulen, commit-queue, dbates, gyuyoung.kim, lforschler, mcatanzaro, ossy | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Joonghun Park
2016-02-03 03:05:43 PST
Created attachment 270569 [details]
Patch
I saw this bug but I decided that nobody needs $additionalCMakeArgs. (In reply to comment #2) > I saw this bug but I decided that nobody needs $additionalCMakeArgs. If the variable doesn't needed anymore, then maybe is it ok to be removed instead? Looks like --cmakeargs works fine with this issue present, so it seems to be a good idea to remove dead code. (In reply to comment #4) > Looks like --cmakeargs works fine with this issue present, so it seems to be > a good idea to remove dead code. All right, then I'm gonna remove this thing immediately. Created attachment 270571 [details]
Patch
LGTM. Comment on attachment 270571 [details] Patch Clearing flags on attachment: 270571 Committed r196085: <http://trac.webkit.org/changeset/196085> All reviewed patches have been landed. Closing bug. |