|Summary:||[Tools] Remove $additionalCMakeArgs variable because without this variable --cmakeargs options works well|
|Product:||WebKit||Reporter:||Joonghun Park <jh718.park>|
|Component:||Tools / Tests||Assignee:||Joonghun Park <jh718.park>|
|Severity:||Normal||CC:||achristensen, annulen, commit-queue, dbates, gyuyoung.kim, lforschler, mcatanzaro, ossy|
|Version:||WebKit Nightly Build|
Description Joonghun Park 2016-02-03 03:05:43 PST
When an array is passed to subroutines as argument in perl, a list containing its element is returned from the array. Currently @$ arguments are being passed, then it is going to be one list including all the elements not only from @ but also from $. As a result, $additionalCMakeArgs in sub generateBuildSystemFromCMakeProject is not being used.
Comment 2 Konstantin Tokarev 2016-02-03 04:39:13 PST
I saw this bug but I decided that nobody needs $additionalCMakeArgs.
Comment 3 Joonghun Park 2016-02-03 04:41:20 PST
(In reply to comment #2) > I saw this bug but I decided that nobody needs $additionalCMakeArgs. If the variable doesn't needed anymore, then maybe is it ok to be removed instead?
Comment 4 Konstantin Tokarev 2016-02-03 04:44:28 PST
Looks like --cmakeargs works fine with this issue present, so it seems to be a good idea to remove dead code.
Comment 5 Joonghun Park 2016-02-03 04:50:36 PST
(In reply to comment #4) > Looks like --cmakeargs works fine with this issue present, so it seems to be > a good idea to remove dead code. All right, then I'm gonna remove this thing immediately.
Comment 7 Konstantin Tokarev 2016-02-03 05:37:49 PST
Comment 8 WebKit Commit Bot 2016-02-03 15:06:56 PST
Comment on attachment 270571 [details] Patch Clearing flags on attachment: 270571 Committed r196085: <http://trac.webkit.org/changeset/196085>
Comment 9 WebKit Commit Bot 2016-02-03 15:07:01 PST
All reviewed patches have been landed. Closing bug.