Bug 15382

Summary: [CAIRO] Canvas pattern support
Product: WebKit Reporter: Alp Toker <alp>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal Keywords: Cairo
Priority: P2    
Version: 523.x (Safari 3)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Add canvas pattern support zecke: review+

Description Alp Toker 2007-10-05 14:42:12 PDT 
The Cairo Canvas implementation currently lacks support for patterns. This should be added to CanvasPattern.cpp.
Comment 1 Alp Toker 2007-12-23 13:11:41 PST 
Created attachment 18073 [details]
Add canvas pattern support
Comment 2 Holger Freyther 2007-12-23 16:48:29 PST 
Comment on attachment 18073 [details]
Add canvas pattern support

-Try to remove the whitespace change to the RGBA32 lines before landing

-Check for !m_cachedImage->image in CanvasPatern::createPattern

-Free the surface in void CanvasRenderingContext2D::drawImage

-The Image/BitmapImage changes somehow remind me of nativeImageForCurrentFrame()
Comment 3 Alp Toker 2007-12-23 19:05:31 PST 
Landed in r28971, complete with the suggested nativeImageForCurrentFrame() change (decided not to copy the other ports but go with this cleaner abstraction).
Comment 4 Alp Toker 2007-12-24 22:20:45 PST 
*** Bug 16519 has been marked as a duplicate of this bug. ***