| Summary: | [JSC] make Object.getOwnPropertyDescriptors() work with non-JSObject types | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Caitlin Potter (:caitp) <caitp> | ||||
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | caitp, commit-queue, darin, ggaren, keith_miller, kling, ljharb, mark.lam, msaboff, saam, youennf, ysuzuki | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Caitlin Potter (:caitp)
2016-02-02 19:44:31 PST
Created attachment 270541 [details]
Patch
Comment on attachment 270541 [details]
Patch
Nice, r=me
Comment on attachment 270541 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=270541&action=review > Source/JavaScriptCore/tests/es6/Object_static_methods_Object.getOwnPropertyDescriptors.js:93 > + // delete global[symbol]; I think I have a fix for this crash (which is shipping in Safari atm :() --- I can include that in a separate bug though, I guess Comment on attachment 270541 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=270541&action=review >> Source/JavaScriptCore/tests/es6/Object_static_methods_Object.getOwnPropertyDescriptors.js:93 >> + // delete global[symbol]; > > I think I have a fix for this crash (which is shipping in Safari atm :() --- I can include that in a separate bug though, I guess OK, could you open a bug for that? Comment on attachment 270541 [details] Patch Clearing flags on attachment: 270541 Committed r196042: <http://trac.webkit.org/changeset/196042> All reviewed patches have been landed. Closing bug. |