Bug 153814

Summary: [JSC] make Object.getOwnPropertyDescriptors() work with non-JSObject types
Product: WebKit Reporter: Caitlin Potter (:caitp) <caitp>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: caitp, commit-queue, darin, ggaren, keith_miller, kling, ljharb, mark.lam, msaboff, saam, youennf, ysuzuki
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Caitlin Potter (:caitp)
Reported 2016-02-02 19:44:31 PST
[JSC] make Object.getOwnPropertyDescriptors() work with non-JSObject types
Attachments
Patch (2.77 KB, patch)
2016-02-02 19:45 PST, Caitlin Potter (:caitp) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Caitlin Potter (:caitp)
Comment 1 2016-02-02 19:45:31 PST
Created attachment 270541 [details] Patch
Yusuke Suzuki
Comment 2 2016-02-02 19:58:24 PST
Comment on attachment 270541 [details] Patch Nice, r=me
Caitlin Potter (:caitp)
Comment 3 2016-02-02 20:14:17 PST
Comment on attachment 270541 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=270541&action=review > Source/JavaScriptCore/tests/es6/Object_static_methods_Object.getOwnPropertyDescriptors.js:93 > + // delete global[symbol]; I think I have a fix for this crash (which is shipping in Safari atm :() --- I can include that in a separate bug though, I guess
Yusuke Suzuki
Comment 4 2016-02-02 20:18:38 PST
Comment on attachment 270541 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=270541&action=review >> Source/JavaScriptCore/tests/es6/Object_static_methods_Object.getOwnPropertyDescriptors.js:93 >> + // delete global[symbol]; > > I think I have a fix for this crash (which is shipping in Safari atm :() --- I can include that in a separate bug though, I guess OK, could you open a bug for that?
WebKit Commit Bot
Comment 5 2016-02-02 20:22:45 PST
Comment on attachment 270541 [details] Patch Clearing flags on attachment: 270541 Committed r196042: <http://trac.webkit.org/changeset/196042>
WebKit Commit Bot
Comment 6 2016-02-02 20:22:51 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.