Bug 153806

Summary: Provide handleKeyWebEvent with completion handler
Product: WebKit Reporter: Enrica Casucci <enrica>
Component: WebKit2Assignee: Enrica Casucci <enrica>
Status: RESOLVED FIXED    
Severity: Normal CC: thorton
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Description Enrica Casucci 2016-02-02 15:17:16 PST 
To support new keyboard architecture.
Comment 1 Enrica Casucci 2016-02-02 15:25:53 PST 
Created attachment 270527 [details]
Patch
Comment 2 Tim Horton 2016-02-02 15:29:36 PST 
Comment on attachment 270527 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=270527&action=review

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:2875
> +    _keyWebEventHandler = [completionHandler copy];

I think we have a smart pointer for blocks now!

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:2885
> +        return;

Confused. Why do you bail here? Don't we still have to do some of the work below?
Comment 3 Enrica Casucci 2016-02-02 15:32:10 PST 
(In reply to comment #2)
> Comment on attachment 270527 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=270527&action=review
> 
> > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:2875
> > +    _keyWebEventHandler = [completionHandler copy];
> 
> I think we have a smart pointer for blocks now!
> 
> > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:2885
> > +        return;
> 
> Confused. Why do you bail here? Don't we still have to do some of the work
> below?

No we don't in this case.
I'll adopt the BlockPtr.
Comment 4 Enrica Casucci 2016-02-02 16:09:55 PST 
Committed revision 196037.