Bug 153788

Summary: WEBGL_debug_shaders should be disabled for OpenGLES backend also
Product: WebKit Reporter: Jinyoung Hur <hur.ims>
Component: WebGLAssignee: Jinyoung Hur <hur.ims>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, kondapallykalyan, noam, roger_fong
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews112 for mac-yosemite
none
Patch none

Description Jinyoung Hur 2016-02-02 07:32:31 PST 
On OpenGLES backed environment, webgl/1.0.2/conformance/extensions/webgl-debug-shaders.html fails with the same error related with https://bugs.webkit.org/show_bug.cgi?id=149734.
I think the codes that are disabling WEBGL_debug_shaders extension, which are implemented in Extensions3DOpenGL::supportsExtension(), should be moved to Extensions3DOpenGLCommon::supportsExtension() so that the webgl-debug-shaders extension is disabled for both OpenGL and OpenGLES backed systems.
Comment 1 Jinyoung Hur 2016-02-02 07:52:31 PST 
Created attachment 270487 [details]
Patch
Comment 2 Build Bot 2016-02-02 08:46:14 PST 
Comment on attachment 270487 [details]
Patch

Attachment 270487 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/772911

New failing tests:
imported/w3c/web-platform-tests/streams-api/readable-streams/garbage-collection-2.html
Comment 3 Build Bot 2016-02-02 08:46:16 PST 
Created attachment 270490 [details]
Archive of layout-test-results from ews112 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 4 Jinyoung Hur 2016-02-02 16:46:30 PST 
Created attachment 270529 [details]
Patch
Comment 5 WebKit Commit Bot 2016-02-02 18:27:32 PST 
Comment on attachment 270529 [details]
Patch

Clearing flags on attachment: 270529

Committed r196039: <http://trac.webkit.org/changeset/196039>
Comment 6 WebKit Commit Bot 2016-02-02 18:27:35 PST 
All reviewed patches have been landed.  Closing bug.