Summary: | Add line grid pagination SPI to WebKit | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dave Hyatt <hyatt> | ||||||
Component: | Layout and Rendering | Assignee: | Dave Hyatt <hyatt> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, esprehn+autocc, glenn, jonlee, kondapallykalyan, simon.fraser | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Dave Hyatt
2016-02-01 13:10:17 PST
Created attachment 270416 [details]
Patch
Attachment 270416 [details] did not pass style-queue:
ERROR: Source/WebCore/rendering/RenderBox.cpp:30: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 1 in 43 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 270419 [details]
Patch
Comment on attachment 270419 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=270419&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:212 > +@property (nonatomic, setter=_setPaginationLineGridEnabled:) BOOL _paginationLineGridEnabled; Does it make any sense to toggle this in a live view? I don't think so. So it should probably be on WKWebViewConfiguration. |