Bug 153757

Summary: Add line grid pagination SPI to WebKit
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: Layout and RenderingAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, jonlee, kondapallykalyan, simon.fraser
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch andersca: review+

Description Dave Hyatt 2016-02-01 13:10:17 PST 
Add line grid pagination SPI to WebKit
Comment 1 Dave Hyatt 2016-02-01 13:15:44 PST 
Created attachment 270416 [details]
Patch
Comment 2 WebKit Commit Bot 2016-02-01 13:18:17 PST 
Attachment 270416 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/RenderBox.cpp:30:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 43 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Dave Hyatt 2016-02-01 13:40:44 PST 
Created attachment 270419 [details]
Patch
Comment 4 Tim Horton 2016-02-02 11:19:45 PST 
Comment on attachment 270419 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=270419&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:212
> +@property (nonatomic, setter=_setPaginationLineGridEnabled:) BOOL _paginationLineGridEnabled;

Does it make any sense to toggle this in a live view? I don't think so. So it should probably be on WKWebViewConfiguration.
Comment 5 Dave Hyatt 2016-02-02 11:50:13 PST 
Fixed in r196024.
Comment 6 Jon Lee 2016-02-02 12:54:11 PST 
rdar://problem/23041598