Bug 153734

Summary: REGRESSION (r194660): Legacy WebProcess crashes in ChildProcess::initializeSandbox()
Product: WebKit Reporter: mitz
Component: WebCore Misc.Assignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, dbates, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch mitz: review+

mitz
Reported 2016-01-31 21:00:07 PST
After <http://trac.webkit.org/r194660>, WebProcess crashes on launch in ChildProcess::initializeSandbox, because parameters.connectionIdentifier.xpcConnection is null in a legacy process.
Attachments
Patch (2.00 KB, patch)
2016-02-01 14:19 PST, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Patch (5.83 KB, patch)
2016-02-02 17:06 PST, Daniel Bates 		mitz: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2016-01-31 21:04:14 PST
I think it is OK to simply have legacy processes always take the “Unsigned, signed by a third party, or has an invalid/malformed signature” branch.
Radar WebKit Bug Importer
Comment 2 2016-01-31 22:56:16 PST
<rdar://problem/24433179>
Daniel Bates
Comment 3 2016-02-01 14:19:08 PST
Created attachment 270425 [details] Patch
Daniel Bates
Comment 4 2016-02-01 14:20:44 PST
I take it that we need to keep around such legacy process support?
Daniel Bates
Comment 5 2016-02-02 17:06:34 PST
Created attachment 270530 [details] Patch
Daniel Bates
Comment 6 2016-02-03 08:34:41 PST
Committed r196066: <http://trac.webkit.org/changeset/196066>
Note You need to log in before you can comment on or make changes to this bug.