Bug 153705

Summary: Use std::make_unique<> when creating an unique_ptr object
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: New BugsAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Gyuyoung Kim
Reported 2016-01-30 05:01:45 PST
Some factory functions have used std::unique_ptr<> instead of std::make_unique<>. In those cases we need to use std::make_unique<> directly.
Attachments
Patch (14.20 KB, patch)
2016-01-30 05:05 PST, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch for landing (14.00 KB, patch)
2016-01-30 20:34 PST, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2016-01-30 05:05:41 PST
Created attachment 270305 [details] Patch
Darin Adler
Comment 2 2016-01-30 11:25:26 PST
Comment on attachment 270305 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=270305&action=review > Source/WebCore/platform/cf/RunLoopObserver.h:41 > + // WEBCORE_EXPORT static std::unique_ptr<RunLoopObserver> create(CFIndex order, RunLoopObserverCallback callback); We should not keep this commented out code.
Gyuyoung Kim
Comment 3 2016-01-30 20:34:31 PST
Created attachment 270336 [details] Patch for landing
Gyuyoung Kim
Comment 4 2016-01-30 20:35:13 PST
(In reply to comment #2) > Comment on attachment 270305 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=270305&action=review > > > Source/WebCore/platform/cf/RunLoopObserver.h:41 > > + // WEBCORE_EXPORT static std::unique_ptr<RunLoopObserver> create(CFIndex order, RunLoopObserverCallback callback); > > We should not keep this commented out code. Oops. Removed.
WebKit Commit Bot
Comment 5 2016-01-31 03:41:52 PST
Comment on attachment 270336 [details] Patch for landing Clearing flags on attachment: 270336 Committed r195925: <http://trac.webkit.org/changeset/195925>
WebKit Commit Bot
Comment 6 2016-01-31 03:41:56 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.