Bug 153667

Summary:

Move more 'constructor' properties to the prototype

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Bindings

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, cgarcia, commit-queue, darin, ggaren, rniwa, sam, webkit-bug-importer

Priority:

Keywords:

InRadar, WebExposed

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

URL:

http://heycam.github.io/webidl/#interface-prototype-object

See Also:

https://bugs.webkit.org/show_bug.cgi?id=148092
https://bugs.webkit.org/show_bug.cgi?id=149412

Attachments:

Description	Flags
WIP Patch	none
Patch	none

Chris Dumez

Reported 2016-01-29 13:30:05 PST

Move more 'constructor' properties to the prototype. Currently, we keep the 'constructor' on the instance for interfaces that have an indexed / named property getter because our getOwnPropertySlot() implementation used to be wrong for such interfaces. However, getOwnPropertySlot() should be correct after <https://bugs.webkit.org/show_bug.cgi?id=148092> so we should be able to move the 'constructor' up to the prototype now.

Attachments
WIP Patch (32.50 KB, patch) 2016-01-29 13:31 PST, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (36.74 KB, patch) 2016-01-29 15:53 PST, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.