Bug 153667

Summary: Move more 'constructor' properties to the prototype
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: BindingsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, cgarcia, commit-queue, darin, ggaren, rniwa, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar, WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: http://heycam.github.io/webidl/#interface-prototype-object
See Also: https://bugs.webkit.org/show_bug.cgi?id=148092
https://bugs.webkit.org/show_bug.cgi?id=149412
Attachments:
Description Flags
WIP Patch
none
Patch none

Description Chris Dumez 2016-01-29 13:30:05 PST 
Move more 'constructor' properties to the prototype. Currently, we keep the 'constructor' on the instance for interfaces that have an indexed / named property getter because our getOwnPropertySlot() implementation used to be wrong for such interfaces.
However, getOwnPropertySlot() should be correct after <https://bugs.webkit.org/show_bug.cgi?id=148092> so we should be able to move the 'constructor' up to the prototype now.
Comment 1 Chris Dumez 2016-01-29 13:31:15 PST 
Created attachment 270248 [details]
WIP Patch
Comment 2 Chris Dumez 2016-01-29 15:53:08 PST 
Created attachment 270268 [details]
Patch
Comment 3 Radar WebKit Bug Importer 2016-01-29 15:56:46 PST 
<rdar://problem/24420095>
Comment 4 Radar WebKit Bug Importer 2016-01-29 15:57:05 PST 
<rdar://problem/24420103>
Comment 5 Chris Dumez 2016-01-30 12:10:25 PST 
Comment on attachment 270268 [details]
Patch

Clearing flags on attachment: 270268

Committed r195904: <http://trac.webkit.org/changeset/195904>
Comment 6 Chris Dumez 2016-01-30 12:10:31 PST 
All reviewed patches have been landed.  Closing bug.