Bug 153658

Summary: B3 should have documentation
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 150279    
Attachments:
Description Flags
the patch
timothy: review+
the patch saam: review+

Description Filip Pizlo 2016-01-29 11:15:18 PST 
Patch forthcoming.
Comment 1 Filip Pizlo 2016-01-29 11:16:35 PST 
Created attachment 270227 [details]
the patch
Comment 2 Filip Pizlo 2016-01-29 11:18:56 PST 
Comment on attachment 270227 [details]
the patch

Landing myself.
Comment 3 Saam Barati 2016-01-29 11:26:18 PST 
Comment on attachment 270227 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=270227&action=review

r=me

> Websites/webkit.org/docs/b3/bare-bones-backend.md:21
> +    printf("%d\n", function(42)); // prints 43

// prints 44

> Websites/webkit.org/docs/b3/bare-bones-backend.md:95
> +Note that the "@" references indicate the origin of the instruction in the B3 IR.

I'd move this sentence up to the unoptimized Air IR above.
Comment 4 Filip Pizlo 2016-01-29 13:36:31 PST 
Landed in http://trac.webkit.org/changeset/195830.  But I will change it.
Comment 5 Filip Pizlo 2016-01-29 13:38:55 PST 
Created attachment 270249 [details]
the patch
Comment 6 Saam Barati 2016-01-29 13:42:32 PST 
Comment on attachment 270249 [details]
the patch

LGTM
Comment 7 Filip Pizlo 2016-01-29 15:00:58 PST 
Landed in http://trac.webkit.org/changeset/195841