Bug 153658 - B3 should have documentation
Summary: B3 should have documentation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 150279
  Show dependency treegraph
 
Reported: 2016-01-29 11:15 PST by Filip Pizlo
Modified: 2016-01-29 15:00 PST (History)
1 user (show)

See Also:


Attachments
the patch (8.34 KB, patch)
2016-01-29 11:16 PST, Filip Pizlo
timothy: review+
Details | Formatted Diff | Diff
the patch (47.97 KB, patch)
2016-01-29 13:38 PST, Filip Pizlo
sbarati: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2016-01-29 11:15:18 PST
Patch forthcoming.
Comment 1 Filip Pizlo 2016-01-29 11:16:35 PST
Created attachment 270227 [details]
the patch
Comment 2 Filip Pizlo 2016-01-29 11:18:56 PST
Comment on attachment 270227 [details]
the patch

Landing myself.
Comment 3 Saam Barati 2016-01-29 11:26:18 PST
Comment on attachment 270227 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=270227&action=review

r=me

> Websites/webkit.org/docs/b3/bare-bones-backend.md:21
> +    printf("%d\n", function(42)); // prints 43

// prints 44

> Websites/webkit.org/docs/b3/bare-bones-backend.md:95
> +Note that the "@" references indicate the origin of the instruction in the B3 IR.

I'd move this sentence up to the unoptimized Air IR above.
Comment 4 Filip Pizlo 2016-01-29 13:36:31 PST
Landed in http://trac.webkit.org/changeset/195830.  But I will change it.
Comment 5 Filip Pizlo 2016-01-29 13:38:55 PST
Created attachment 270249 [details]
the patch
Comment 6 Saam Barati 2016-01-29 13:42:32 PST
Comment on attachment 270249 [details]
the patch

LGTM
Comment 7 Filip Pizlo 2016-01-29 15:00:58 PST
Landed in http://trac.webkit.org/changeset/195841