Bug 153655

Summary: Disable text interaction with pencil
Product: WebKit Reporter: Enrica Casucci <enrica>
Component: WebKit2Assignee: Enrica Casucci <enrica>
Status: RESOLVED FIXED    
Severity: Normal CC: ryanhaddad, thorton
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Description Enrica Casucci 2016-01-29 10:29:11 PST 
We don't want the pencil to be used for selecting text or zoom.

rdar://problem/24337778
Comment 1 Enrica Casucci 2016-01-29 10:33:28 PST 
Created attachment 270222 [details]
Patch
Comment 2 Tim Horton 2016-01-29 10:38:38 PST 
Comment on attachment 270222 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=270222&action=review

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:437
> +    _doubleTapGestureRecognizer.get().allowedTouchTypes = @[@(UITouchTypeDirect)];

[_doubleTapGestureRecognizer allowedTouchTypes] (we do prefer dot notation but not in the case where you have to do this horrible .get(). thing, I think.
spaces inside the @[]

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1336
> +    UITouch *touch = (UITouch *)[gestureRecognizer.touches lastObject];

Do you really need this cast? Should be id -> UITouch * which should work without complaint.
Comment 3 Enrica Casucci 2016-01-29 11:09:16 PST 
Committed revision 195826.