Bug 153655

Summary: Disable text interaction with pencil
Product: WebKit Reporter: Enrica Casucci <enrica>
Component: WebKit2Assignee: Enrica Casucci <enrica>
Status: RESOLVED FIXED    
Severity: Normal CC: ryanhaddad, thorton
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Enrica Casucci
Reported 2016-01-29 10:29:11 PST
We don't want the pencil to be used for selecting text or zoom. rdar://problem/24337778
Attachments
Patch (2.28 KB, patch)
2016-01-29 10:33 PST, Enrica Casucci 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Enrica Casucci
Comment 1 2016-01-29 10:33:28 PST
Created attachment 270222 [details] Patch
Tim Horton
Comment 2 2016-01-29 10:38:38 PST
Comment on attachment 270222 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=270222&action=review > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:437 > + _doubleTapGestureRecognizer.get().allowedTouchTypes = @[@(UITouchTypeDirect)]; [_doubleTapGestureRecognizer allowedTouchTypes] (we do prefer dot notation but not in the case where you have to do this horrible .get(). thing, I think. spaces inside the @[] > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1336 > + UITouch *touch = (UITouch *)[gestureRecognizer.touches lastObject]; Do you really need this cast? Should be id -> UITouch * which should work without complaint.
Enrica Casucci
Comment 3 2016-01-29 11:09:16 PST
Committed revision 195826.
Note You need to log in before you can comment on or make changes to this bug.