Bug 153619

Summary:

update-webkit-dependency fails to fetch updates through firewall on Windows

Product:

WebKit

Reporter:

Nikos Andronikos <nikos.andronikos>

Component:

Tools / Tests

Assignee:

Nikos Andronikos <nikos.andronikos>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, lforschler, mmaxfield

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Windows 7

Attachments:

Description	Flags
Patch	none

Description Nikos Andronikos 2016-01-28 15:12:20 PST

On Windows, when a firewall is present we need to read proxy settings from environment variables.

Comment 1 Nikos Andronikos 2016-01-28 15:27:34 PST

Created attachment 270154 [details]
Patch

Comment 2 Nikos Andronikos 2016-01-28 15:28:13 PST

We should update http://trac.webkit.org/wiki/WindowsWithoutCygwin to note that HTTP_PROXY and HTTPS_PROXY should be set as required.

Comment 3 WebKit Commit Bot 2016-01-29 15:01:09 PST

Comment on attachment 270154 [details]
Patch

Clearing flags on attachment: 270154

Committed r195843: <http://trac.webkit.org/changeset/195843>

Comment 4 WebKit Commit Bot 2016-01-29 15:01:14 PST

All reviewed patches have been landed.  Closing bug.