Bug 153619 - update-webkit-dependency fails to fetch updates through firewall on Windows
Summary: update-webkit-dependency fails to fetch updates through firewall on Windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Windows 7
: P2 Normal
Assignee: Nikos Andronikos
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-28 15:12 PST by Nikos Andronikos
Modified: 2016-01-29 15:01 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.47 KB, patch)
2016-01-28 15:27 PST, Nikos Andronikos 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikos Andronikos 2016-01-28 15:12:20 PST 
On Windows, when a firewall is present we need to read proxy settings from environment variables.
Comment 1 Nikos Andronikos 2016-01-28 15:27:34 PST 
Created attachment 270154 [details]
Patch
Comment 2 Nikos Andronikos 2016-01-28 15:28:13 PST 
We should update http://trac.webkit.org/wiki/WindowsWithoutCygwin to note that HTTP_PROXY and HTTPS_PROXY should be set as required.
Comment 3 WebKit Commit Bot 2016-01-29 15:01:09 PST 
Comment on attachment 270154 [details]
Patch

Clearing flags on attachment: 270154

Committed r195843: <http://trac.webkit.org/changeset/195843>
Comment 4 WebKit Commit Bot 2016-01-29 15:01:14 PST 
All reviewed patches have been landed.  Closing bug.