Bug 153614

Summary: Modern IDB: SQLite backend doesn't handle mutation during cursor iteration
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebCore Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, alecflett, commit-queue, jsbell
Priority: P2    
Version: Safari 9   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 149117, 153021    
Attachments:
Description Flags
Patch v1 achristensen: review+

Brady Eidson
Reported 2016-01-28 13:44:54 PST
Modern IDB: SQLite backend doesn't handle mutation during cursor iteration
Attachments
Patch v1 (7.78 KB, patch)
2016-01-28 14:47 PST, Brady Eidson 		achristensen: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2016-01-28 14:47:33 PST
Created attachment 270147 [details] Patch v1
Brady Eidson
Comment 2 2016-01-28 14:53:47 PST
http://trac.webkit.org/changeset/195784
Andy Estes
Comment 3 2016-01-28 14:54:48 PST
Comment on attachment 270147 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=270147&action=review > Source/WebCore/Modules/indexeddb/server/SQLiteIDBTransaction.cpp:137 > + auto backingStoreTake = m_backingStoreCursors.take(&cursor); > + if (backingStoreTake) { How about if (auto* takenBackingStore = m_backingStoreCursors.take(&cursor)) { takenBackingStore seems like a better name than backingStoreTake.
Note You need to log in before you can comment on or make changes to this bug.