Bug 153614

Summary:

Modern IDB: SQLite backend doesn't handle mutation during cursor iteration

Product:

WebKit

Reporter:

Brady Eidson <beidson>

Component:

WebCore Misc.

Assignee:

Brady Eidson <beidson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, alecflett, commit-queue, jsbell

Priority:

Version:

Safari 9

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

149117, 153021

Attachments:

Description	Flags
Patch v1	achristensen: review+

Description Brady Eidson 2016-01-28 13:44:54 PST

Modern IDB: SQLite backend doesn't handle mutation during cursor iteration

Comment 1 Brady Eidson 2016-01-28 14:47:33 PST

Created attachment 270147 [details]
Patch v1

Comment 2 Brady Eidson 2016-01-28 14:53:47 PST

http://trac.webkit.org/changeset/195784

Comment 3 Andy Estes 2016-01-28 14:54:48 PST

Comment on attachment 270147 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=270147&action=review

> Source/WebCore/Modules/indexeddb/server/SQLiteIDBTransaction.cpp:137
> +    auto backingStoreTake = m_backingStoreCursors.take(&cursor);
> +    if (backingStoreTake) {

How about if (auto* takenBackingStore = m_backingStoreCursors.take(&cursor)) {

takenBackingStore seems like a better name than backingStoreTake.