Bug 153601
| Summary: | [GTK][EFL] Make gtk & efl port use s same media controls code. | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | ChangSeok Oh <changseok> |
| Component: | Media | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Normal | CC: | bugs-noreply, calvaris, changseok, gyuyoung.kim, jh718.park, mcatanzaro |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
ChangSeok Oh
In bug 151816, Xabier mentioned his thought on merging mediaControlsGtk.js and mediaControlsBase.js and making gtk & efl port use a same code base, mediaControlsBase.js. This is a follow-up.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Xabier Rodríguez Calvar
Ossy, we were discussing about merging EFL and GTK+ media controls since you are using Base, that is a fork of an earlier version of the Apple ones.
The discussion is under https://bugs.webkit.org/show_bug.cgi?id=151816#c19.
I could take care of the review and such, but since we are changing your look and feel, you might want to say a word :)
Csaba Osztrogonác
I don't have any time nowadays, maybe the others have some opinion about it.
Gyuyoung Kim
(In reply to comment #2)
> I don't have any time nowadays, maybe the others have some opinion about it.
I post a comment there.
https://bugs.webkit.org/show_bug.cgi?id=151816#c28
Xabier Rodríguez Calvar
Answering the comment in bug 151816.
(In reply to comment #28)
> Basically I think the way is that we go. EFL had owned media control theme.
> But it was very poor quality controls. That's why we have used Apple's base
> media control themes. If EFL is continue to use base theme without GTK
> dependency when merging base + GTK+, I don't have any reason to object this
> plan.
If you don't have issues now, you shouldn't have them after the merge. The only issues might be some icons or things like that, that can be easily solved with CSS or theming.
Anyway, the way to go, IMHO, would be to make the merge directly into, mediaControlsGTK, make GTK+ use only that file instead of Base+GTK and once that is ready, we can rename that into Base and polish any details in EFL. That would allow working only in one port until everything is ready.
Michael Catanzaro
EFL port has been removed.