Bug 153599

Summary: Move attributes to the prototype for List types / and types with indexed/named property getters
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: BindingsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, buildbot, cgarcia, commit-queue, darin, ggaren, kling, koivisto, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar, WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=151453
https://bugs.webkit.org/show_bug.cgi?id=148871
https://bugs.webkit.org/show_bug.cgi?id=148092
https://bugs.webkit.org/show_bug.cgi?id=148039
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews102 for mac-yosemite
none
Patch none

Description Chris Dumez 2016-01-28 10:27:20 PST 
Move attributes to the prototype for List types / and types with indexed/named property getters.

We used to keep them on the instance because:
1. Our GetOwnProperty lookup used to be in incorrect order for interfaces with indexed/named property getters.
-> This was fixed recently and we now match the specification and other browsers.
2. This used to regress performance when iterating over those list types
-> Local testing seems to show that this is no longer a regression (tested Speedometer and various related Bindings PerformanceTests).
Comment 1 Chris Dumez 2016-01-28 10:29:52 PST 
Created attachment 270126 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2016-01-28 10:34:05 PST 
<rdar://problem/24391745>
Comment 3 Build Bot 2016-01-28 14:24:11 PST 
Comment on attachment 270126 [details]
Patch

Attachment 270126 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/752198

New failing tests:
imported/w3c/web-platform-tests/html/dom/interfaces.html
Comment 4 Build Bot 2016-01-28 14:24:16 PST 
Created attachment 270146 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 5 Chris Dumez 2016-01-28 16:05:31 PST 
Created attachment 270157 [details]
Patch
Comment 6 WebKit Commit Bot 2016-01-28 19:42:50 PST 
Comment on attachment 270157 [details]
Patch

Clearing flags on attachment: 270157

Committed r195798: <http://trac.webkit.org/changeset/195798>
Comment 7 WebKit Commit Bot 2016-01-28 19:42:57 PST 
All reviewed patches have been landed.  Closing bug.