Bug 153595

Summary: EventHandler IDL attributes should be enumerable
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, esprehn+autocc, kangil.han, koivisto, kondapallykalyan, rniwa
Priority: P2 Keywords: WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2016-01-28 09:08:48 PST
Most of our EventHandler IDL attributes are marked as [NotEnumerable] but should not be according to the specification: - https://html.spec.whatwg.org/#globaleventhandlers - https://html.spec.whatwg.org/#windoweventhandlers Firefox and Chrome behave according to the specification.
Attachments
Patch (33.76 KB, patch)
2016-01-28 09:39 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (33.82 KB, patch)
2016-01-28 09:46 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-01-28 09:39:53 PST
Created attachment 270121 [details] Patch
Chris Dumez
Comment 2 2016-01-28 09:46:15 PST
Created attachment 270123 [details] Patch
Sam Weinig
Comment 3 2016-01-28 10:14:55 PST
Comment on attachment 270123 [details] Patch r=me. Do you know why these were marked [NotEnumerable] in the first place (there is good chance I did it and can't remember)?
Chris Dumez
Comment 4 2016-01-28 11:07:41 PST
(In reply to comment #3) > Comment on attachment 270123 [details] > Patch > > r=me. Do you know why these were marked [NotEnumerable] in the first place > (there is good chance I did it and can't remember)? It is not easy to tell because this was done a very long time ago and these have moved around.
WebKit Commit Bot
Comment 5 2016-01-28 12:35:26 PST
Comment on attachment 270123 [details] Patch Clearing flags on attachment: 270123 Committed r195778: <http://trac.webkit.org/changeset/195778>
WebKit Commit Bot
Comment 6 2016-01-28 12:35:32 PST
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 7 2016-01-28 17:23:53 PST
Yes, Sam, you did it in http://trac.webkit.org/changeset/36977 and there is no indication why!
Darin Adler
Comment 8 2016-01-28 17:24:11 PST
I was the reviewer.
Note You need to log in before you can comment on or make changes to this bug.