Summary: | [GStreamer] MediaPlayerPrivateGStreamerBase::handleSyncMessage leaks GstContext | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gwang Yoon Hwang <yoon> | ||||||
Component: | New Bugs | Assignee: | Gwang Yoon Hwang <yoon> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | clopez, commit-queue, pnormand | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Gwang Yoon Hwang
2016-01-27 21:13:29 PST
Created attachment 270088 [details]
Patch
Comment on attachment 270088 [details]
Patch
This actually needs GRefPtr template specialization for GstContext.
Created attachment 270098 [details]
Patch
(In reply to comment #2) > Comment on attachment 270088 [details] > Patch > > This actually needs GRefPtr template specialization for GstContext. Good point! Fixed to do that Comment on attachment 270098 [details]
Patch
Thanks :)
Comment on attachment 270098 [details] Patch Clearing flags on attachment: 270098 Committed r195735: <http://trac.webkit.org/changeset/195735> All reviewed patches have been landed. Closing bug. (In reply to comment #6) > Comment on attachment 270098 [details] > Patch > > Clearing flags on attachment: 270098 > > Committed r195735: <http://trac.webkit.org/changeset/195735> Seems this has indirectly raised the build dependency for GSTreamer to > 1.1 version, because gst_context_ref() is not available on 1.0.x 1.1 ? There is no such version yet. Ok so we need an #ifdef around this. (In reply to comment #9) > 1.1 ? There is no such version yet. 1.1.1 i mean (In reply to comment #8) > (In reply to comment #6) > > Comment on attachment 270098 [details] > > Patch > > > > Clearing flags on attachment: 270098 > > > > Committed r195735: <http://trac.webkit.org/changeset/195735> > > Seems this has indirectly raised the build dependency for GSTreamer to > 1.1 > version, because gst_context_ref() is not available on 1.0.x To be fair, r195735 didn't caused this. It seems this was happening since at least r181499, because gst_context_new() is also not available on 1.0.x ? (In reply to comment #10) > Ok so we need an #ifdef around this. Or maybe is better to just raise the gstreamer minimum version on cmake ? |