Bug 153568

Summary:

B3 IntRange analysis should know more about shifting

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, benjamin, commit-queue, ggaren, keith_miller, mark.lam, mhahnenb, msaboff, oliver, saam, sam

Priority:

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

Attachments:

Description	Flags
the patch	benjamin: review+, benjamin: commit-queue-

Filip Pizlo

Reported 2016-01-27 15:43:34 PST

This will help remove another overflow check in Octane/encrypt.

Attachments
the patch (5.80 KB, patch) 2016-01-27 15:47 PST, Filip Pizlo	benjamin: review+ benjamin: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Filip Pizlo

Comment 1 2016-01-27 15:47:16 PST

Benjamin Poulain

Comment 2 2016-01-27 16:55:03 PST

Comment on attachment 270055 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=270055&action=review > Source/JavaScriptCore/b3/B3ReduceStrength.cpp:280 > + return sShr<int32_t>(shiftAmount); int32_t?

Filip Pizlo

Comment 3 2016-01-27 20:23:46 PST

(In reply to comment #2) > Comment on attachment 270055 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=270055&action=review > > > Source/JavaScriptCore/b3/B3ReduceStrength.cpp:280 > > + return sShr<int32_t>(shiftAmount); > > int32_t? That's embarrassing.

Filip Pizlo

Comment 4 2016-01-27 20:24:13 PST

I'll write some tests before landing this.

Filip Pizlo

Comment 5 2016-01-27 21:22:43 PST

Note You need to log in before you can comment on or make changes to this bug.