Summary: | Add Event.deepPath() and Event.scoped | ||
---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
Component: | DOM | Assignee: | Ryosuke Niwa <rniwa> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | buildbot, cdumez, cgarcia, commit-queue, esprehn+autocc, kangil.han, koivisto, kondapallykalyan, rniwa, webkit-bug-importer |
Priority: | P2 | Keywords: | InRadar |
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Bug Depends on: | 155285, 155327 | ||
Bug Blocks: | 148695 | ||
Attachments: |
Description
Ryosuke Niwa
2016-01-26 23:47:36 PST
*** Bug 155283 has been marked as a duplicate of this bug. *** Created attachment 273698 [details]
Adds the support
Attachment 273698 [details] did not pass style-queue:
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestEventConstructor.cpp:218: One line control clauses should not use braces. [whitespace/braces] [4]
Total errors found: 1 in 29 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 273698 [details] Adds the support Attachment 273698 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/959444 New failing tests: fast/shadow-dom/trusted-event-scoped-flags.html fast/shadow-dom/negative-tabindex-on-shadow-host.html Created attachment 273709 [details]
Archive of layout-test-results from ews101 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 273698 [details] Adds the support Attachment 273698 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/959449 New failing tests: fast/shadow-dom/negative-tabindex-on-shadow-host.html Created attachment 273710 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Comment on attachment 273698 [details] Adds the support Attachment 273698 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/959447 New failing tests: fast/shadow-dom/trusted-event-scoped-flags.html Created attachment 273711 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.10.5
Comment on attachment 273698 [details] Adds the support Attachment 273698 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/959452 New failing tests: fast/shadow-dom/trusted-event-scoped-flags.html fast/shadow-dom/negative-tabindex-on-shadow-host.html Created attachment 273712 [details]
Archive of layout-test-results from ews116 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 273698 [details] Adds the support View in context: https://bugs.webkit.org/attachment.cgi?id=273698&action=review r=me assuming you address whatever is causing the tests to fail > Source/WebCore/dom/EventPath.cpp:249 > + // Use Vector instead of HashSet since we expect the number of ancestor tree scopes to be small. Expecting the number to be small, and not caring at all about the performance of pathological cases are two different things. Is this really the right tradeoff all the time? > Source/WebCore/dom/EventPath.h:51 > + void computePathDisclosedToTarget(const EventTarget&, Vector<EventTarget*>&) const; Why not have this return a Vector instead of using an out argument? (In reply to comment #13) > Comment on attachment 273698 [details] > Adds the support > > View in context: > https://bugs.webkit.org/attachment.cgi?id=273698&action=review > > r=me assuming you address whatever is causing the tests to fail Fixed the test. I was missing m_relatedTarget check in FocusEvent. > > Source/WebCore/dom/EventPath.cpp:249 > > + // Use Vector instead of HashSet since we expect the number of ancestor tree scopes to be small. > > Expecting the number to be small, and not caring at all about the > performance of pathological cases are two different things. Is this really > the right tradeoff all the time? I think so. Nobody uses shadow DOM API today but this vector grows as much as there are number of ancestor shadow trees, and I don't think it can ever grow behind a small number (e.g. 8-10). We can revisit this design if it becomes a problem in practice. It's hard to make decisions given the lack of contents that use these APIs. > > Source/WebCore/dom/EventPath.h:51 > > + void computePathDisclosedToTarget(const EventTarget&, Vector<EventTarget*>&) const; > > Why not have this return a Vector instead of using an out argument? Fixed. Created attachment 273788 [details]
Patch for landing
Comment on attachment 273788 [details]
Patch for landing
Wait for EWS
Attachment 273788 [details] did not pass style-queue:
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestEventConstructor.cpp:218: One line control clauses should not use braces. [whitespace/braces] [4]
Total errors found: 1 in 31 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 273788 [details] Patch for landing Attachment 273788 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/963179 New failing tests: fast/shadow-dom/trusted-event-scoped-flags.html Created attachment 273791 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.10.5
Comment on attachment 273788 [details] Patch for landing Attachment 273788 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/963231 New failing tests: fast/shadow-dom/trusted-event-scoped-flags.html Created attachment 273792 [details]
Archive of layout-test-results from ews117 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117 Port: mac-yosemite Platform: Mac OS X 10.10.5
Created attachment 273793 [details]
Patch for landing 2
Attachment 273793 [details] did not pass style-queue:
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestEventConstructor.cpp:218: One line control clauses should not use braces. [whitespace/braces] [4]
Total errors found: 1 in 32 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 273793 [details] Patch for landing 2 View in context: https://bugs.webkit.org/attachment.cgi?id=273793&action=review > LayoutTests/platform/ios-simulator/fast/shadow-dom/trusted-event-scoped-flags-expected.txt:19 > +FAIL input.type = "text"; log(input, "mousemove"); eventSender.mouseMoveTo(x, y); eventType should be mousemove (of type string). Was undefined (of type undefined). iOS doesn't support eventSender so these tests would fail there. Committed r198056: <http://trac.webkit.org/changeset/198056> Mass move bugs into the DOM component. |