Bug 153534

Summary: Rename HTMLSlotElement.getDistributedNodes to getAssignedNodes
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: DOMAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cdumez, commit-queue, esprehn+autocc, gyuyoung.kim, kling, koivisto, kondapallykalyan, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 148695    
Attachments:
Description Flags
Renames the method
none
Archive of layout-test-results from ews101 for mac-yosemite
none
Archive of layout-test-results from ews105 for mac-yosemite-wk2
none
Archive of layout-test-results from ews115 for mac-yosemite
none
rebaselined the test koivisto: review+

Description Ryosuke Niwa 2016-01-26 21:50:28 PST
The shadow DOM API spec has been updated not to only assign Element and Text nodes to a slot element in
https://github.com/w3c/webcomponents/commit/f986bf803e6bf092a2f23ea08359abd8722f9aac

Update our implementation to reflect that.
Comment 1 Ryosuke Niwa 2016-01-26 22:45:22 PST
Created attachment 269983 [details]
Renames the method
Comment 2 Build Bot 2016-01-26 23:36:44 PST
Comment on attachment 269983 [details]
Renames the method

Attachment 269983 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/744465

New failing tests:
fast/shadow-dom/HTMLSlotElement-interface.html
Comment 3 Build Bot 2016-01-26 23:36:47 PST
Created attachment 269985 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 4 Build Bot 2016-01-26 23:40:45 PST
Comment on attachment 269983 [details]
Renames the method

Attachment 269983 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/744473

New failing tests:
fast/shadow-dom/HTMLSlotElement-interface.html
Comment 5 Build Bot 2016-01-26 23:40:48 PST
Created attachment 269986 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 6 Build Bot 2016-01-26 23:51:27 PST
Comment on attachment 269983 [details]
Renames the method

Attachment 269983 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/744467

New failing tests:
fast/shadow-dom/HTMLSlotElement-interface.html
Comment 7 Build Bot 2016-01-26 23:51:30 PST
Created attachment 269988 [details]
Archive of layout-test-results from ews115 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 8 Ryosuke Niwa 2016-01-27 11:21:11 PST
Created attachment 270013 [details]
rebaselined the test
Comment 9 Ryosuke Niwa 2016-01-27 12:08:58 PST
Committed r195681: <http://trac.webkit.org/changeset/195681>