Summary: | Generalize ResourceUsageData gathering to be used outside of ResourceUsageOverlay | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||
Component: | Web Inspector | Assignee: | Joseph Pecoraro <joepeck> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | barraclough, bburg, commit-queue, ggaren, graouts, joepeck, kling, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 153516 | ||||||
Attachments: |
|
Description
Joseph Pecoraro
2016-01-26 13:56:34 PST
Created attachment 269916 [details]
[PATCH] Proposed Fix
Attachment 269916 [details] did not pass style-queue:
ERROR: Source/WebCore/page/ResourceUsageThread.h:49: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebCore/page/ResourceUsageThread.h:68: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebCore/page/ResourceUsageData.h:63: The parameter name "data" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/WebCore/page/ResourceUsageThread.cpp:48: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebCore/page/ResourceUsageThread.cpp:83: Extra space before ( in function call [whitespace/parens] [4]
Total errors found: 5 in 24 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 269916 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=269916&action=review r=me > Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:173 > + ASSERT(categories.size = d.categories.size); > + for (size_t i = 0; i < categories.size; ++i) size() vs size = vs == Comment on attachment 269916 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=269916&action=review > Source/WebCore/page/scrolling/ScrollingThread.cpp:54 > - std::lock_guard<Lock> lock(singleton().m_functionsMutex); > + std::lock_guard<Lock> lock(scrollingThread.m_functionsMutex); joe pls |