Bug 153497

Summary: [webkitdirs] isCMakeBuild should be true by default
Product: WebKit Reporter: Konstantin Tokarev <annulen>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, dbates, lforschler
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Konstantin Tokarev 2016-01-26 11:57:37 PST
Since all ports use CMake or are migrating to it, new ports should be encouraged to use CMake as well. So isCMakeBuild should return true by default.
Comment 1 Konstantin Tokarev 2016-01-26 11:58:20 PST
Created attachment 269901 [details]
Patch
Comment 2 Michael Catanzaro 2016-01-26 12:59:26 PST
Comment on attachment 269901 [details]
Patch

It looks like isAppleMacWebKit() returns true for iOS, so I think this is fine.
Comment 3 WebKit Commit Bot 2016-01-26 13:14:41 PST
Comment on attachment 269901 [details]
Patch

Clearing flags on attachment: 269901

Committed r195613: <http://trac.webkit.org/changeset/195613>
Comment 4 WebKit Commit Bot 2016-01-26 13:14:45 PST
All reviewed patches have been landed.  Closing bug.