Bug 153497

Summary: [webkitdirs] isCMakeBuild should be true by default
Product: WebKit Reporter: Konstantin Tokarev <annulen>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, dbates, lforschler
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Konstantin Tokarev
Reported 2016-01-26 11:57:37 PST
Since all ports use CMake or are migrating to it, new ports should be encouraged to use CMake as well. So isCMakeBuild should return true by default.
Attachments
Patch (1.06 KB, patch)
2016-01-26 11:58 PST, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Konstantin Tokarev
Comment 1 2016-01-26 11:58:20 PST
Created attachment 269901 [details] Patch
Michael Catanzaro
Comment 2 2016-01-26 12:59:26 PST
Comment on attachment 269901 [details] Patch It looks like isAppleMacWebKit() returns true for iOS, so I think this is fine.
WebKit Commit Bot
Comment 3 2016-01-26 13:14:41 PST
Comment on attachment 269901 [details] Patch Clearing flags on attachment: 269901 Committed r195613: <http://trac.webkit.org/changeset/195613>
WebKit Commit Bot
Comment 4 2016-01-26 13:14:45 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.