Bug 153496

Summary: [webkitdirs] Removed check for bison, gperf, and flex.
Product: WebKit Reporter: Konstantin Tokarev <annulen>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, dbates, lforschler
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Konstantin Tokarev 2016-01-26 11:47:00 PST
bison, gperf, and flex are basic prerequisites of build, and condition already included all ports present in trunk.
Comment 1 Konstantin Tokarev 2016-01-26 11:48:12 PST
Created attachment 269899 [details]
Patch
Comment 2 Konstantin Tokarev 2016-01-26 11:48:45 PST
Also removed outdated comment from 2006.
Comment 3 Alex Christensen 2016-01-26 12:57:22 PST
Comment on attachment 269899 [details]
Patch

I think we could completely remove this check.  They are done in WebKitCommon.cmake, and bison, gperf, and flex don't necessarily need to be in the PATH
Comment 4 Konstantin Tokarev 2016-01-26 13:23:25 PST
Created attachment 269910 [details]
Patch
Comment 5 WebKit Commit Bot 2016-01-26 13:38:30 PST
Comment on attachment 269910 [details]
Patch

Clearing flags on attachment: 269910

Committed r195617: <http://trac.webkit.org/changeset/195617>
Comment 6 WebKit Commit Bot 2016-01-26 13:38:33 PST
All reviewed patches have been landed.  Closing bug.