Bug 153481

Summary: [GTK][EFL] Rename ScrollAnimationNone as ScrollAnimationSmooth
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, bugs-noreply, commit-queue, gyuyoung.kim, ossy, simon.fraser
Priority: P2 Keywords: Gtk
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 153405    
Attachments:
Description Flags
Patch
none
Fix the build simon.fraser: review+

Carlos Garcia Campos
Reported 2016-01-26 05:20:49 PST
ScrollAnimationNone has always been used by EFL and GTK port to implement smooth scrolling. I think it should be possible for other scroll animators to implement smooth scrolling or even implement other kind of scroll animations. For example, in the future I would like to have kinetic scrolling implemented for the GTK+ port to match all other GTK+ application and decide at runtime between different animations without having to use a different scroll animator class.
Attachments
Patch (68.36 KB, patch)
2016-01-26 05:34 PST, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Fix the build (68.36 KB, patch)
2016-01-26 05:55 PST, Carlos Garcia Campos 		simon.fraser: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2016-01-26 05:34:28 PST
Created attachment 269877 [details] Patch For bug #153230 I plan to add ScrollAnimatorGtk to implement overlay scrollbars and use ScrollAnimationSmooth to still support smooth scrolling without using ScrollAnimatorSmooth.
WebKit Commit Bot
Comment 2 2016-01-26 05:35:47 PST
Attachment 269877 [details] did not pass style-queue: ERROR: Source/WebCore/platform/ScrollAnimationSmooth.cpp:43: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/ScrollAnimationSmooth.h:46: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/ScrollAnimationSmooth.h:103: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 3 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Carlos Garcia Campos
Comment 3 2016-01-26 05:55:04 PST
Created attachment 269878 [details] Fix the build
WebKit Commit Bot
Comment 4 2016-01-26 05:56:45 PST
Attachment 269878 [details] did not pass style-queue: ERROR: Source/WebCore/platform/ScrollAnimationSmooth.cpp:43: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/ScrollAnimationSmooth.h:46: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/ScrollAnimationSmooth.h:103: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 3 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Carlos Garcia Campos
Comment 5 2016-01-27 02:33:17 PST
Committed r195661: <http://trac.webkit.org/changeset/195661>
Note You need to log in before you can comment on or make changes to this bug.