Bug 153475

Summary: Allow canvas to use display-list drawing for testing
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cdumez, commit-queue, esprehn+autocc, gyuyoung.kim, rniwa, sabouhallawa, simon.fraser, thorton, zalan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 152808    
Attachments:
Description Flags
Patch
none
Patch
none
Archive of layout-test-results from ews100 for mac-yosemite
none
Archive of layout-test-results from ews115 for mac-yosemite
none
Patch dino: review+

Description Simon Fraser (smfr) 2016-01-25 22:36:58 PST
Allow canvas to use display-list drawing for testing
Comment 1 Simon Fraser (smfr) 2016-01-25 22:42:36 PST
Created attachment 269850 [details]
Patch
Comment 2 Simon Fraser (smfr) 2016-01-25 22:45:34 PST
Created attachment 269852 [details]
Patch
Comment 3 Build Bot 2016-01-25 23:12:09 PST
Comment on attachment 269852 [details]
Patch

Attachment 269852 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/739998

Number of test failures exceeded the failure limit.
Comment 4 Build Bot 2016-01-25 23:12:13 PST
Created attachment 269854 [details]
Archive of layout-test-results from ews100 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 5 Build Bot 2016-01-25 23:22:46 PST
Comment on attachment 269852 [details]
Patch

Attachment 269852 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/740025

Number of test failures exceeded the failure limit.
Comment 6 Build Bot 2016-01-25 23:22:50 PST
Created attachment 269855 [details]
Archive of layout-test-results from ews115 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 7 Simon Fraser (smfr) 2016-01-25 23:24:23 PST
Created attachment 269857 [details]
Patch
Comment 8 Dean Jackson 2016-01-26 17:42:39 PST
Comment on attachment 269857 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=269857&action=review

> Source/WebCore/html/canvas/CanvasRenderingContext2D.h:60
> +namespace DisplayList {
> +typedef unsigned AsTextFlags;
> +}

I don't think you need this. CRC2D includes CRC, which includes HTMLCanvasElement, and you put this typedef there already.

> LayoutTests/displaylists/canvas-display-list-expected.txt:2
> +(

This is never closed.
Comment 9 Simon Fraser (smfr) 2016-01-26 17:53:40 PST
https://trac.webkit.org/r195646