Bug 153427

Summary: Modern IDB: Key generator support for SQLite backend
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebCore Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, alecflett, commit-queue, jsbell
Priority: P2    
Version: Safari 9   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 149117, 153021    
Attachments:
Description Flags
Patch v1
none
Patch for landing none

Brady Eidson
Reported 2016-01-25 10:16:32 PST
Modern IDB: Key generator support for SQLite backend
Attachments
Patch v1 (12.78 KB, patch)
2016-01-26 17:07 PST, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch for landing (12.56 KB, patch)
2016-01-26 17:19 PST, Brady Eidson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2016-01-26 17:07:56 PST
Created attachment 269954 [details] Patch v1
Brady Eidson
Comment 2 2016-01-26 17:19:44 PST
Created attachment 269956 [details] Patch for landing
Alex Christensen
Comment 3 2016-01-26 17:25:47 PST
Comment on attachment 269954 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=269954&action=review > Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:1244 > + if (static_cast<uint64_t>(currentValue) > maxGeneratorValue) static_cast not necessary.
WebKit Commit Bot
Comment 4 2016-01-26 18:26:07 PST
Comment on attachment 269956 [details] Patch for landing Clearing flags on attachment: 269956 Committed r195648: <http://trac.webkit.org/changeset/195648>
WebKit Commit Bot
Comment 5 2016-01-26 18:26:10 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.