Summary: | Modern IDB: Implement getIndexRecord in the SQLite backing store | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||
Component: | WebCore Misc. | Assignee: | Brady Eidson <beidson> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | achristensen, alecflett, commit-queue, jsbell | ||||
Priority: | P2 | ||||||
Version: | Safari 9 | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 149117, 153021 | ||||||
Attachments: |
|
Description
Brady Eidson
2016-01-25 09:17:44 PST
Created attachment 269754 [details]
Patch v1
Comment on attachment 269754 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=269754&action=review > Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:1150 > + getResult = { SharedBuffer::create(cursor->currentValueBuffer().data(), cursor->currentValueBuffer().size()) }; Is there a way to do this without copying? SharedBuffer knows how to adopt a Vector<char> but not a Vector<uint8_t>. Might be a topic worth returning to. (In reply to comment #2) > Comment on attachment 269754 [details] > Patch v1 > > View in context: > https://bugs.webkit.org/attachment.cgi?id=269754&action=review > > > Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:1150 > > + getResult = { SharedBuffer::create(cursor->currentValueBuffer().data(), cursor->currentValueBuffer().size()) }; > > Is there a way to do this without copying? SharedBuffer knows how to adopt a > Vector<char> but not a Vector<uint8_t>. Might be a topic worth returning to. Definitely plan on returning to this. Right now I'm trying to shovel over the WebKit2 SQLite backend with minimal changes, but I definitely plan to give it a once over afterwards. Thanks! Comment on attachment 269754 [details] Patch v1 Clearing flags on attachment: 269754 Committed r195541: <http://trac.webkit.org/changeset/195541> All reviewed patches have been landed. Closing bug. |