Modern IDB: Implement deleteIndex and getCount for the SQLite backing store

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Brady Eidson]

Modern IDB: Implement deleteIndex and getCount for the SQLite backing store

[Brady Eidson]

Created attachment 269720 [details]
Patch v1

[Darin Adler]

Comment on attachment 269720 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=269720&action=review

> Source/WebCore/Modules/indexeddb/server/SQLiteIDBCursor.cpp:88
> +    if (!m_indexID)
> +        m_indexID = IDBIndexMetadata::InvalidId;

Could do this with ? : in the initializer.

    , m_indexID(m_indexID ? m_indexID : IDBIndexMetadata::InvalidId)

[Build Bot]

Comment on attachment 269720 [details]
Patch v1

Attachment 269720 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/735392

New failing tests:
imported/w3c/web-platform-tests/streams-api/readable-streams/garbage-collection.html

[Build Bot]

Created attachment 269722 [details]
Archive of layout-test-results from ews116 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Brady Eidson]

(In reply to comment #3)
> Comment on attachment 269720 [details]
> Patch v1
> 
> Attachment 269720 [details] did not pass mac-debug-ews (mac):
> Output: http://webkit-queues.webkit.org/results/735392
> 
> New failing tests:
> imported/w3c/web-platform-tests/streams-api/readable-streams/garbage-
> collection.html

Just knowing a test named this failed, it's unclear how this patch caused it.

Looking into it...

[Brady Eidson]

Created attachment 269725 [details]
Patch for landing

Perhaps EWS hiccuped or something...?

Made the change Darin suggested and re-uploading for CQ. Running tests locally and will let EWS run as well.

[Brady Eidson]

The test that crashed was doing some JSGlobalObject task on a worker thread, but all of the IndexedDB tests that use workers are currently disabled.

I don't see how this was at fault.

[Brady Eidson]

Definitely did not see this locally over two full test runs.

[WebKit Commit Bot]

Comment on attachment 269725 [details]
Patch for landing

Clearing flags on attachment: 269725

Committed r195527: <http://trac.webkit.org/changeset/195527>