| Summary: | Web Inspector: Highlight timeline range handles on hover | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Nikita Vasilyev <nvasilyev> | ||||||||||||||||
| Component: | Web Inspector | Assignee: | Nikita Vasilyev <nvasilyev> | ||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||
| Severity: | Normal | CC: | bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||
| Hardware: | All | ||||||||||||||||||
| OS: | All | ||||||||||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=153376 | ||||||||||||||||||
| Attachments: |
|
||||||||||||||||||
Created attachment 269651 [details]
[Animated GIF] With the patch applied
Cool! No patch is attached. I am not sure I expected blue for the state. A darker grey would better match tics controls on the system. Created attachment 269652 [details]
Patch
(In reply to comment #3) > Cool! No patch is attached. Attached three minutes after your comment :) > I am not sure I expected blue for the state. A darker grey would better > match tics controls on the system. I'm fine with dark grey. Any tics controls I should look at? I couldn't recall similar UI anywhere on OS X. Things like the tab close buttons in Inspector and Safari. Created attachment 269683 [details]
Patch
Created attachment 269684 [details]
Patch
Created attachment 269685 [details]
[Animated GIF] With the patch applied
Comment on attachment 269684 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=269684&action=review > Source/WebInspectorUI/UserInterface/Views/TimelineRuler.css:192 > + background-color: hsl(212, 0%, 50%); Why not 0 for hue? Created attachment 269705 [details]
Patch
Comment on attachment 269705 [details] Patch Clearing flags on attachment: 269705 Committed r195519: <http://trac.webkit.org/changeset/195519> All reviewed patches have been landed. Closing bug. |
Created attachment 269647 [details] [Animated GIF] Current behavior See the attached animated GIF. When clicking on a timeline range handler that is too close to the edge, it isn't clear what is going to be resized, the sidebar or the timeline range selector. To mitigate the issue, we should highlight range handles on hover.