Bug 153395

Summary: Web Inspector: Highlight timeline range handles on hover
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=153376
Attachments:
Description Flags
[Animated GIF] Current behavior
none
[Animated GIF] With the patch applied
none
Patch
none
Patch
none
Patch
timothy: review+
[Animated GIF] With the patch applied
none
Patch none

Nikita Vasilyev
Reported 2016-01-22 21:47:07 PST
Created attachment 269647 [details] [Animated GIF] Current behavior See the attached animated GIF. When clicking on a timeline range handler that is too close to the edge, it isn't clear what is going to be resized, the sidebar or the timeline range selector. To mitigate the issue, we should highlight range handles on hover.
Attachments
[Animated GIF] Current behavior (354.20 KB, image/gif)
2016-01-22 21:47 PST, Nikita Vasilyev 		no flags
Details
[Animated GIF] With the patch applied (468.96 KB, image/gif)
2016-01-22 21:59 PST, Nikita Vasilyev 		no flags
Details
Patch (1.75 KB, patch)
2016-01-22 22:06 PST, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
Patch (1.72 KB, patch)
2016-01-23 23:42 PST, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
Patch (1.75 KB, patch)
2016-01-23 23:47 PST, Nikita Vasilyev 		timothy: review+
DetailsFormatted DiffDiff
[Animated GIF] With the patch applied (175.42 KB, image/gif)
2016-01-23 23:51 PST, Nikita Vasilyev 		no flags
Details
Patch (1.75 KB, patch)
2016-01-24 15:59 PST, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-01-22 21:47:21 PST
<rdar://problem/24312364>
Nikita Vasilyev
Comment 2 2016-01-22 21:59:37 PST
Created attachment 269651 [details] [Animated GIF] With the patch applied
Timothy Hatcher
Comment 3 2016-01-22 22:03:08 PST
Cool! No patch is attached. I am not sure I expected blue for the state. A darker grey would better match tics controls on the system.
Nikita Vasilyev
Comment 4 2016-01-22 22:06:10 PST
Created attachment 269652 [details] Patch
Nikita Vasilyev
Comment 5 2016-01-22 22:45:17 PST
(In reply to comment #3) > Cool! No patch is attached. Attached three minutes after your comment :) > I am not sure I expected blue for the state. A darker grey would better > match tics controls on the system. I'm fine with dark grey. Any tics controls I should look at? I couldn't recall similar UI anywhere on OS X.
Timothy Hatcher
Comment 6 2016-01-23 08:37:28 PST
Things like the tab close buttons in Inspector and Safari.
Nikita Vasilyev
Comment 7 2016-01-23 23:42:09 PST
Created attachment 269683 [details] Patch
Nikita Vasilyev
Comment 8 2016-01-23 23:47:42 PST
Created attachment 269684 [details] Patch
Nikita Vasilyev
Comment 9 2016-01-23 23:51:33 PST
Created attachment 269685 [details] [Animated GIF] With the patch applied
Timothy Hatcher
Comment 10 2016-01-24 11:26:17 PST
Comment on attachment 269684 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=269684&action=review > Source/WebInspectorUI/UserInterface/Views/TimelineRuler.css:192 > + background-color: hsl(212, 0%, 50%); Why not 0 for hue?
Nikita Vasilyev
Comment 11 2016-01-24 15:59:42 PST
Created attachment 269705 [details] Patch
WebKit Commit Bot
Comment 12 2016-01-24 16:59:08 PST
Comment on attachment 269705 [details] Patch Clearing flags on attachment: 269705 Committed r195519: <http://trac.webkit.org/changeset/195519>
WebKit Commit Bot
Comment 13 2016-01-24 16:59:12 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.