Bug 153384

Summary: Use Symbol.species in the builtin TypedArray.prototype functions
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Archive of layout-test-results from ews114 for mac-yosemite
none
Patch
none
Patch none

Keith Miller
Reported 2016-01-22 17:23:43 PST
Use Symbol.species in the builtin TypedArray.prototype functions
Attachments
Patch (26.01 KB, patch)
2016-01-22 17:36 PST, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (28.06 KB, patch)
2016-02-19 12:05 PST, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (28.46 KB, patch)
2016-02-19 12:08 PST, Keith Miller 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews114 for mac-yosemite (544.68 KB, application/zip)
2016-02-19 12:50 PST, Build Bot 		no flags
Details
Patch (28.08 KB, patch)
2016-02-19 13:20 PST, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (28.08 KB, patch)
2016-02-22 11:07 PST, Keith Miller 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2016-01-22 17:36:33 PST
Created attachment 269626 [details] Patch
Keith Miller
Comment 2 2016-01-25 15:54:50 PST
I think this patch is actually not quite right since the constructors are not supposed to be called.
Geoffrey Garen
Comment 3 2016-02-04 10:53:47 PST
Comment on attachment 269626 [details] Patch r- based on Keith's last comment.
Keith Miller
Comment 4 2016-02-19 12:05:16 PST
Created attachment 271772 [details] Patch
Keith Miller
Comment 5 2016-02-19 12:08:32 PST
Created attachment 271773 [details] Patch
Keith Miller
Comment 6 2016-02-19 12:10:01 PST
I have updated this patch with the correct version of the ES6 spec.
Build Bot
Comment 7 2016-02-19 12:50:56 PST
Comment on attachment 271773 [details] Patch Attachment 271773 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/855659 Number of test failures exceeded the failure limit.
Build Bot
Comment 8 2016-02-19 12:50:58 PST
Created attachment 271787 [details] Archive of layout-test-results from ews114 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-yosemite Platform: Mac OS X 10.10.5
Keith Miller
Comment 9 2016-02-19 13:20:32 PST
Created attachment 271793 [details] Patch
Keith Miller
Comment 10 2016-02-22 11:07:12 PST
Created attachment 271929 [details] Patch
Geoffrey Garen
Comment 11 2016-02-22 11:33:20 PST
Comment on attachment 271929 [details] Patch r=me
WebKit Commit Bot
Comment 12 2016-02-22 12:07:47 PST
Comment on attachment 271929 [details] Patch Clearing flags on attachment: 271929 Committed r196950: <http://trac.webkit.org/changeset/196950>
WebKit Commit Bot
Comment 13 2016-02-22 12:07:51 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.