| Summary: | Modern IDB: Add transactions and create/delete object store to SQLite backend | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||||
| Component: | WebCore Misc. | Assignee: | Brady Eidson <beidson> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | achristensen, alecflett, commit-queue, jsbell | ||||||
| Priority: | P2 | ||||||||
| Version: | Safari 9 | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 149117, 153021 | ||||||||
| Attachments: |
|
||||||||
|
Description
Brady Eidson
2016-01-22 10:33:13 PST
Created attachment 269581 [details]
Patch v1
This patch makes a few tests fail worse than they used to (text failure becomes timeout/ASSERT), but that's okay - It's expected that the tests are still very rough at this stage.
The handful of regressions is more than offset by the many tests that now pass.
Created attachment 269590 [details]
Patch v2
Comment on attachment 269581 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=269581&action=review > Source/WebCore/Modules/indexeddb/server/MemoryIDBBackingStore.cpp:478 > + auto objectStore = m_objectStoresByName.take(objectStoreByIdentifier->info().name()); This is unused. Comment on attachment 269590 [details] Patch v2 Clearing flags on attachment: 269590 Committed r195467: <http://trac.webkit.org/changeset/195467> All reviewed patches have been landed. Closing bug. |