Bug 153356

Summary:

Style resolver initialization cleanups

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

CSS

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, kling, rniwa, simon.fraser

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	simon.fraser: review+, buildbot: commit-queue-
Archive of layout-test-results from ews100 for mac-yosemite	none
Archive of layout-test-results from ews116 for mac-yosemite	none
for bots	none

Antti Koivisto

Reported 2016-01-22 09:48:30 PST

Simplify StyleResolver::State initialization.

Attachments
patch (34.98 KB, patch) 2016-01-22 10:04 PST, Antti Koivisto	simon.fraser: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-yosemite (803.86 KB, application/zip) 2016-01-22 10:55 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews116 for mac-yosemite (873.38 KB, application/zip) 2016-01-22 11:00 PST, Build Bot	no flags	Details
for bots (35.30 KB, patch) 2016-01-22 11:13 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Antti Koivisto

Comment 1 2016-01-22 10:04:48 PST

Created attachment 269577 [details] patch

Simon Fraser (smfr)

Comment 2 2016-01-22 10:11:32 PST

Comment on attachment 269577 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=269577&action=review > Source/WebCore/css/StyleResolver.h:453 > - EInsideLink m_elementLinkState; > + EInsideLink m_elementLinkState { NotInsideLink }; > > - bool m_elementAffectedByClassRules; > + bool m_elementAffectedByClassRules { false }; > > - bool m_applyPropertyToRegularStyle; > - bool m_applyPropertyToVisitedLinkStyle; > + bool m_applyPropertyToRegularStyle { true }; > + bool m_applyPropertyToVisitedLinkStyle { false }; > > PendingImagePropertyMap m_pendingImageProperties; > > Vector<RefPtr<ReferenceFilterOperation>> m_filtersWithPendingSVGDocuments; > > - bool m_fontDirty; > - bool m_fontSizeHasViewportUnits; > + bool m_fontDirty { false }; > + bool m_fontSizeHasViewportUnits { false }; > > - bool m_hasUAAppearance; > + bool m_hasUAAppearance { false }; > BorderData m_borderData; > - FillLayer m_backgroundData; > + FillLayer m_backgroundData { BackgroundFillLayer }; > Color m_backgroundColor; Would be nice to pack all the bools and small enums together to save space.

Build Bot

Comment 3 2016-01-22 10:55:17 PST

Comment on attachment 269577 [details] patch Attachment 269577 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/726167 New failing tests: imported/blink/printing/print-document-without-documentElement-crash.html

Build Bot

Comment 4 2016-01-22 10:55:20 PST

Created attachment 269582 [details] Archive of layout-test-results from ews100 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 5 2016-01-22 11:00:28 PST

Comment on attachment 269577 [details] patch Attachment 269577 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/726162 New failing tests: imported/blink/printing/print-document-without-documentElement-crash.html

Build Bot

Comment 6 2016-01-22 11:00:31 PST

Created attachment 269585 [details] Archive of layout-test-results from ews116 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-yosemite Platform: Mac OS X 10.10.5

Antti Koivisto

Comment 7 2016-01-22 11:13:47 PST

Created attachment 269587 [details] for bots

Antti Koivisto

Comment 8 2016-01-22 12:07:13 PST

https://trac.webkit.org/r195465

Note You need to log in before you can comment on or make changes to this bug.