Bug 153326

Summary: [iOS] Crash in _endPotentialTapAndEnableDoubleTapGesturesIfNecessary
Product: WebKit Reporter: Dean Jackson <dino>
Component: WebKit2Assignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch andersca: review+

Dean Jackson
Reported 2016-01-21 14:44:42 PST
We're getting a lot of reports of crashes in -[WKContentView(WKInteraction) _endPotentialTapAndEnableDoubleTapGesturesIfNecessary] <rdar://problem/24264339>
Attachments
Patch (3.75 KB, patch)
2016-01-21 15:07 PST, Dean Jackson 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dean Jackson
Comment 1 2016-01-21 15:07:11 PST
Created attachment 269500 [details] Patch
Anders Carlsson
Comment 2 2016-01-21 15:17:05 PST
Comment on attachment 269500 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=269500&action=review > Source/WebKit2/UIProcess/ios/WKContentView.h:78 > +- (void)_disconnectWebView; Maybe call this _webViewDestroyed instead? > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1259 > - if (_webView._allowsDoubleTapGestures) > + if (_webView && _webView._allowsDoubleTapGestures) No need to check _webView for nil here. _allowsDoubleTapGestures will return false if _webView is nil.
Dean Jackson
Comment 3 2016-01-21 15:36:49 PST
Committed r195424: <http://trac.webkit.org/changeset/195424>
Note You need to log in before you can comment on or make changes to this bug.