Bug 153324

Summary:

[JSC] foldPathConstants() makes invalid assumptions with Switch

Product:

WebKit

Reporter:

Benjamin Poulain <benjamin>

Component:

New Bugs

Assignee:

Benjamin Poulain <benjamin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, keith_miller, mark.lam, msaboff, saam

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Benjamin Poulain 2016-01-21 14:32:38 PST

[JSC] foldPathConstants() makes invalid assumptions with Switch

Comment 1 Benjamin Poulain 2016-01-21 14:38:21 PST

Created attachment 269494 [details]
Patch

Comment 2 Filip Pizlo 2016-01-21 14:39:58 PST

Comment on attachment 269494 [details]
Patch

Please don't do this.  Switch needs to be revealed to tail duplication in order to get benefits on chains of MultiGetByOffset/MultiPutByOffset.

Comment 3 Benjamin Poulain 2016-01-21 14:51:57 PST

Created attachment 269497 [details]
Patch

Comment 4 Benjamin Poulain 2016-01-21 14:56:29 PST

Comment on attachment 269497 [details]
Patch

Clearing flags on attachment: 269497

Committed r195422: <http://trac.webkit.org/changeset/195422>

Comment 5 Benjamin Poulain 2016-01-21 14:56:32 PST

All reviewed patches have been landed.  Closing bug.