Bug 153297

Summary: Revert to dispatching the popstate event synchronously
Product: WebKit Reporter: Andy Estes <aestes>
Component: New BugsAssignee: Andy Estes <aestes>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, bfulgham, cdumez, commit-queue, darin, enrica, esprehn+autocc, japhet, kangil.han, rniwa, sam, thorton
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch bfulgham: review+, bfulgham: commit-queue-

Andy Estes
Reported 2016-01-20 19:11:26 PST
Re-enable synchronous popstate event for safari-601-branch
Attachments
Patch (6.01 KB, patch)
2016-01-20 19:29 PST, Andy Estes 		bfulgham: review+
bfulgham: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andy Estes
Comment 1 2016-01-20 19:11:57 PST
rdar://problem/24154417
Andy Estes
Comment 2 2016-01-20 19:29:56 PST
Created attachment 269416 [details] Patch
Brent Fulgham
Comment 3 2016-01-21 10:13:16 PST
Comment on attachment 269416 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=269416&action=review r=me. This should only be landed in the branch. > LayoutTests/fast/loader/stateobjects/popstate-is-asynchronous-expected.txt:-8 > -Set hash to #foo It seems weird that we don't output this. Surely the "Set hash to #foo" step is being taken, right?
Andy Estes
Comment 4 2016-01-21 17:44:18 PST
Comment on attachment 269416 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=269416&action=review >> LayoutTests/fast/loader/stateobjects/popstate-is-asynchronous-expected.txt:-8 >> -Set hash to #foo > > It seems weird that we don't output this. Surely the "Set hash to #foo" step is being taken, right? It is weird, but expected. The popstate event handler finishes the test when it fires in response to setting location.hash to "#foo". With synchronous event dispatch, that means the test finishes before we get to the next line that logs "Set hash to #foo".
Andy Estes
Comment 5 2016-02-19 01:29:41 PST
Committed r196807: <http://trac.webkit.org/changeset/196807>
Note You need to log in before you can comment on or make changes to this bug.