Bug 153295

Summary:

Remove irrelevant controls from open source flakiness dashboard and do a minor UI cleanup

Product:

WebKit

Reporter:

Dean Johnson <dean_johnson>

Component:

Tools / Tests

Assignee:

Dean Johnson <dean_johnson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dean_johnson, lforschler

Priority:

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Before patch	none
After patch	none
Patch	none

Dean Johnson

Reported 2016-01-20 17:28:17 PST

Frankly, the current UI hasn't had much work or had much maintenance since the Blink fork. There's dropdowns with only one option (Group: [TOT WebKit], Test type: [layout-tests]), text is misleading/unclear and formatted poorly, and generally speaking the dashboard is somewhat unpleasant to look at. Let's see what we can do to improve the aesthetics of the UI.

Attachments
Patch (7.05 KB, patch) 2016-01-20 18:59 PST, Dean Johnson	no flags	Details Formatted Diff Diff
Before patch (1.63 MB, image/png) 2016-01-21 11:55 PST, Dean Johnson	no flags	Details
After patch (1.68 MB, image/png) 2016-01-21 11:55 PST, Dean Johnson	no flags	Details
Patch (7.51 KB, patch) 2016-08-04 17:11 PDT, Dean Johnson	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Dean Johnson

Comment 1 2016-01-20 18:59:23 PST

Created attachment 269413 [details] Patch

Dean Johnson

Comment 2 2016-01-21 11:55:25 PST

Created attachment 269477 [details] Before patch

Dean Johnson

Comment 3 2016-01-21 11:55:46 PST

Created attachment 269478 [details] After patch

Dean Johnson

Comment 4 2016-01-21 11:59:44 PST

Added some before/after pictures of the webpage. Also, the rationale behind leaving the Test type: dropdown with only the layout-test option is that I think it's totally plausible to have other tests types on the dashboard in the future, even if we don't now. If this is something we really don't expect and really is just clutter on the page, I'm fine removing it.

Dean Johnson

Comment 5 2016-01-21 14:27:49 PST

Updated title to more accurately reflect the purpose of what this bug should be tracking.

Darin Adler

Comment 6 2016-01-22 09:29:48 PST

Comment on attachment 269413 [details] Patch Looks OK.

Dean Johnson

Comment 7 2016-08-04 17:11:31 PDT

Created attachment 285382 [details] Patch

WebKit Commit Bot

Comment 8 2016-08-04 17:47:27 PDT

Comment on attachment 285382 [details] Patch Clearing flags on attachment: 285382 Committed r204156: <http://trac.webkit.org/changeset/204156>

WebKit Commit Bot

Comment 9 2016-08-04 17:47:31 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.