Summary: | AX: [IOS] Implement next/previous text marker functions using TextIterator | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Nan Wang <n_wang> | ||||||
Component: | Accessibility | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, n_wang, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=152728 | ||||||||
Attachments: |
|
Description
Nan Wang
2016-01-20 16:04:49 PST
Created attachment 269409 [details]
patch
Comment on attachment 269409 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=269409&action=review > Source/WebCore/ChangeLog:11 > + Also, fixed an issue in AXObjectCache that creating a range with a replaced node AXObjectCache that creating - >AXObjectCache where creating did you add a test case for this issue you fixed? > Source/WebCore/accessibility/AXObjectCache.cpp:1551 > + remove unused line > Source/WebCore/accessibility/AXObjectCache.cpp:1577 > + bool startNodeIsReplacedOrBR = AccessibilityObject::replacedNodeNeedsCharacter(startNode) || startNode->hasTagName(brTag); can you put this code block in a helper method > Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:2506 > + if (!start || !end) can you make a helper method in WebAccessibilityTextMarker that takes a Range and returns an array of the WebAccessibilityTextMarker > Tools/DumpRenderTree/ios/AccessibilityUIElementIOS.mm:485 > + return 0; return nullptr; > Tools/DumpRenderTree/ios/AccessibilityUIElementIOS.mm:490 > + return 0; return nullptr; > Tools/DumpRenderTree/ios/AccessibilityUIElementIOS.mm:495 > + return 0; return nullptr; > Tools/DumpRenderTree/ios/AccessibilityUIElementIOS.mm:535 > + return 0; return nullptr; Comment on attachment 269409 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=269409&action=review Will address these comments. Thanks. >> Source/WebCore/ChangeLog:11 >> + Also, fixed an issue in AXObjectCache that creating a range with a replaced node > > AXObjectCache that creating - >AXObjectCache where creating > > did you add a test case for this issue you fixed? Yes, it's covered in the test when calling textMarkerRangeForMarkers. Created attachment 269411 [details]
patch
review comments
Comment on attachment 269411 [details] patch Clearing flags on attachment: 269411 Committed r195405: <http://trac.webkit.org/changeset/195405> All reviewed patches have been landed. Closing bug. |