Bug 153274 – [jhbuild] build error in LLVM OCaml bindings

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Frédéric Wang (:fredw)]

Created attachment 269350 [details]
Patch disabling OCaml bindings

On Debian testing, update-webkitgtk-libs fails to build LLVM. The failure happens when compiling llvm_executionengine.ml with the error

"Error: Unbound value Ctypes.raw_address_of_ptr"

One workaround is to disable the OCaml bindings (see for example https://github.com/Homebrew/homebrew/commit/c246ee22c19e5c97d3c6b311877dc0aca342bae1) but I'm not sure whether this is problematic for WebKit's need, though.

[Frédéric Wang (:fredw)]

Created attachment 272653 [details]
Patch

[Frédéric Wang (:fredw)]

I still have this problem. I'm not sure whether I'm the only one but I'm asking review to at least get feedback on whether OCaml binding is really needed for WebKit. If it's not then it's safe to take this patch, that will solve my problem and even speed-up update-webkitgtk-libs for everybody.

[Csaba Osztrogonác]

Shouldn't we simply remove llvm from jhbuild?

Now FTL JIT uses B3 and all LLVM related thing
was removed from the trunk.

[Michael Catanzaro]

Comment on attachment 272653 [details]
Patch

Yes, please just remove llvm, nothing needs it anymore.

[Frédéric Wang (:fredw)]

Created attachment 272662 [details]
Patch

[Frédéric Wang (:fredw)]

Committed r197495: <http://trac.webkit.org/changeset/197495>

[Michael Catanzaro]

joanie:  mcatanzaro: (or anyone) http://www.fpaste.org/337290/18831145/
joanie:  look familiar and/or hints?
mcatanzaro:  joanie: Ooops, it's my fault
mcatanzaro:  I told fwang to remove llvm from our internal jhbuild, because WebKit no longer diirectly depends on LLVM. I said "nothing depends on it anymore"
mcatanzaro:  joanie: But we still need it, else it's a crapshoot whether mesa will build, because LLVM has no stable API.
mcatanzaro:  The problem is the mesa is our jhbuild environment is way too old for the LLVM in Fedora 24
joanie:  i downgraded this machine to f23
joanie:  and figured it was something I did
mcatanzaro:  joanie: It's probably too old for the LLVM in F23, then

[Michael Catanzaro]

joanie:  so what do you suggest?
mcatanzaro:  joanie: I'm gonna roll out the change that broke it, then fwang can submit another patch
joanie:  thank you

[WebKit Commit Bot]

Re-opened since this is blocked by bug 155369

[WebKit Commit Bot]

Comment on attachment 272653 [details]
Patch

Clearing flags on attachment: 272653

Committed r198029: <http://trac.webkit.org/changeset/198029>