Bug 153264

Summary: DocumentType.publicId / systemId should never return null
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, kangil.han, kondapallykalyan, rniwa
Priority: P2 Keywords: WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: https://dom.spec.whatwg.org/#interface-documenttype
See Also: https://bugs.webkit.org/show_bug.cgi?id=160167
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2016-01-19 18:29:47 PST
DocumentType.publicId / systemId should never return null as these attributes are not nullable in the IDL: https://dom.spec.whatwg.org/#interface-documenttype Instead we should return the empty string. Firefox and Chrome match the specification.
Attachments
Patch (16.58 KB, patch)
2016-01-19 18:33 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-01-19 18:33:16 PST
Created attachment 269324 [details] Patch
WebKit Commit Bot
Comment 2 2016-01-19 20:06:41 PST
Comment on attachment 269324 [details] Patch Clearing flags on attachment: 269324 Committed r195336: <http://trac.webkit.org/changeset/195336>
WebKit Commit Bot
Comment 3 2016-01-19 20:06:49 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.