Bug 153264

Summary: DocumentType.publicId / systemId should never return null
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, kangil.han, kondapallykalyan, rniwa
Priority: P2 Keywords: WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: https://dom.spec.whatwg.org/#interface-documenttype
See Also: https://bugs.webkit.org/show_bug.cgi?id=160167
Attachments:
Description Flags
Patch none

Description Chris Dumez 2016-01-19 18:29:47 PST 
DocumentType.publicId / systemId should never return null as these attributes are not nullable in the IDL:
https://dom.spec.whatwg.org/#interface-documenttype

Instead we should return the empty string. Firefox and Chrome match the specification.
Comment 1 Chris Dumez 2016-01-19 18:33:16 PST 
Created attachment 269324 [details]
Patch
Comment 2 WebKit Commit Bot 2016-01-19 20:06:41 PST 
Comment on attachment 269324 [details]
Patch

Clearing flags on attachment: 269324

Committed r195336: <http://trac.webkit.org/changeset/195336>
Comment 3 WebKit Commit Bot 2016-01-19 20:06:49 PST 
All reviewed patches have been landed.  Closing bug.