Bug 153207

Summary: Use PLATFORM(WIN) instead of OS(WINDOWS)
Product: WebKit Reporter: Vitaliy Slobodin <vitaliy.slobodin>
Component: Web Template FrameworkAssignee: Nobody <webkit-unassigned>
Status: RESOLVED WONTFIX    
Severity: Normal CC: achristensen, benjamin, cdumez, cmarcelo, commit-queue
Priority: P2    
Version: WebKit Local Build   
Hardware: PC   
OS: Windows 10   
Attachments:
Description Flags
Patch achristensen: review-, achristensen: commit-queue-

Vitaliy Slobodin
Reported 2016-01-18 08:48:43 PST
Use PLATFORM(WIN) to fix building ports on Windows which require their own implementation of WorkQueue.
Attachments
Patch (1.78 KB, patch)
2016-01-18 08:58 PST, Vitaliy Slobodin 		achristensen: review-
achristensen: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Vitaliy Slobodin
Comment 1 2016-01-18 08:58:35 PST
Created attachment 269225 [details] Patch
Alex Christensen
Comment 2 2016-01-18 22:22:48 PST
What building does this fix?
Vitaliy Slobodin
Comment 3 2016-01-18 23:06:55 PST
(In reply to comment #2) > What building does this fix? Officially unsupported Qt (QtWebkit) port. We're reviving QtWebkit port. And we would like to have the upstream version of Webkit. Unfortunately, the upstream version has places (preprocessor macros) like this one which blocks the porting process. This change doesn't break anything but allows us to use the upstream version. As a side note: we have no plans to upstream QtWebkit in foreseeable future. Thanks.
Alex Christensen
Comment 4 2016-01-19 12:53:16 PST
Is this the only such change needed? If you're not upstreaming it, then you will probably have to manage a lot of such changes. Why will putting this change in the WebKit repository help anything?
Vitaliy Slobodin
Comment 5 2016-01-19 13:41:44 PST
(In reply to comment #4) > Is this the only such change needed? If you're not upstreaming it, then you > will probably have to manage a lot of such changes. Why will putting this > change in the WebKit repository help anything? I was going to type my points of view. But I realized that you are absolutely right. It will be best and correct to keep Qt-specific things in our source tree only. We will handle it on our end. Should I mark it as resolved? And sorry for the inconvenience! Thanks!
Alex Christensen
Comment 6 2016-01-19 18:25:22 PST
No problem.
Note You need to log in before you can comment on or make changes to this bug.