Summary: | Modern IDB: Add private-browsing variant for many IDB tests, and enable private browsing in Modern IDB | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||||
Component: | WebCore Misc. | Assignee: | Brady Eidson <beidson> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | achristensen, alecflett, commit-queue, jsbell, sam | ||||||
Priority: | P2 | ||||||||
Version: | Other | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 153181 | ||||||||
Bug Blocks: | 149117 | ||||||||
Attachments: |
|
Description
Brady Eidson
2016-01-15 20:37:35 PST
Retitled: Modern IDB: Add private-browsing variant for many IDB tests, and enable private browsing in Modern IDB Created attachment 269237 [details]
Patch v1
Attachment 269237 [details] did not pass style-queue:
WARNING: Not running on native Windows.
ERROR: LayoutTests/platform/wk2/TestExpectations:767: Path does not exist. [test/expectations] [5]
ERROR: LayoutTests/platform/wk2/TestExpectations:824: Path does not exist. [test/expectations] [5]
ERROR: LayoutTests/platform/wk2/TestExpectations:825: Path does not exist. [test/expectations] [5]
ERROR: LayoutTests/platform/wk2/TestExpectations:826: Path does not exist. [test/expectations] [5]
ERROR: LayoutTests/platform/wk2/TestExpectations:827: Path does not exist. [test/expectations] [5]
ERROR: LayoutTests/platform/wk2/TestExpectations:828: Path does not exist. [test/expectations] [5]
ERROR: LayoutTests/platform/wk2/TestExpectations:839: Path does not exist. [test/expectations] [5]
ERROR: LayoutTests/platform/wk2/TestExpectations:872: Path does not exist. [test/expectations] [5]
ERROR: LayoutTests/platform/wk2/TestExpectations:881: Line contains tab character. [whitespace/tab] [5]
Total errors found: 9 in 308 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 269237 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=269237&action=review > LayoutTests/resources/js-test.js:10 > + testRunner.setPrivateBrowsingEnabled(true); tab here, should be 4 spaces > Source/WebCore/ChangeLog:8 > + Tests: storage/indexeddb/aborted-versionchange-closes-private.html I don’t think this list of tests is valuable. (In reply to comment #4) > Comment on attachment 269237 [details] > Patch v1 > > View in context: > https://bugs.webkit.org/attachment.cgi?id=269237&action=review > > > LayoutTests/resources/js-test.js:10 > > + testRunner.setPrivateBrowsingEnabled(true); > > tab here, should be 4 spaces Whoops! > > Source/WebCore/ChangeLog:8 > > + Tests: storage/indexeddb/aborted-versionchange-closes-private.html > > I don’t think this list of tests is valuable. Agreed. Thanks! Created attachment 269252 [details]
Patch for EWS then landing
I'll watch the EWS run on this then CQ+ once it's good.
Comment on attachment 269252 [details] Patch for EWS then landing Clearing flags on attachment: 269252 Committed r195247: <http://trac.webkit.org/changeset/195247> All reviewed patches have been landed. Closing bug. |