Bug 153174

Summary:

Remove GraphicsContext::drawConvexPolygon() and GraphicsContext::clipConvexPolygon()

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

New Bugs

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, sabouhallawa, simon.fraser, zalan

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	sam: review+

Simon Fraser (smfr)

Reported 2016-01-15 19:48:26 PST

Remove GraphicsContext::drawConvexPolygon() and GraphicsContext::clipConvexPolygon()

Attachments
Patch (45.87 KB, patch) 2016-01-15 19:52 PST, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Patch (46.65 KB, patch) 2016-01-15 20:32 PST, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Patch (46.68 KB, patch) 2016-01-16 09:16 PST, Simon Fraser (smfr)	sam: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Simon Fraser (smfr)

Comment 1 2016-01-15 19:52:14 PST

Created attachment 269139 [details] Patch

WebKit Commit Bot

Comment 2 2016-01-15 19:53:08 PST

Attachment 269139 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/RenderElement.cpp:2061: Extra space after ( [whitespace/parens] [2] ERROR: Source/WebCore/rendering/RenderElement.cpp:2062: Extra space after ( [whitespace/parens] [2] ERROR: Source/WebCore/rendering/RenderElement.cpp:2066: Extra space after ( [whitespace/parens] [2] ERROR: Source/WebCore/rendering/RenderElement.cpp:2069: Extra space after ( [whitespace/parens] [2] ERROR: Source/WebCore/rendering/RenderElement.cpp:2074: Extra space after ( [whitespace/parens] [2] ERROR: Source/WebCore/rendering/RenderElement.cpp:2075: Extra space after ( [whitespace/parens] [2] ERROR: Source/WebCore/rendering/RenderElement.cpp:2078: Extra space after ( [whitespace/parens] [2] ERROR: Source/WebCore/rendering/RenderElement.cpp:2079: Extra space after ( [whitespace/parens] [2] Total errors found: 8 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.

Simon Fraser (smfr)

Comment 3 2016-01-15 20:32:07 PST

Created attachment 269144 [details] Patch

WebKit Commit Bot

Comment 4 2016-01-15 20:34:45 PST

Attachment 269144 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/RenderElement.cpp:2061: Extra space after ( [whitespace/parens] [2] ERROR: Source/WebCore/rendering/RenderElement.cpp:2062: Extra space after ( [whitespace/parens] [2] ERROR: Source/WebCore/rendering/RenderElement.cpp:2066: Extra space after ( [whitespace/parens] [2] ERROR: Source/WebCore/rendering/RenderElement.cpp:2069: Extra space after ( [whitespace/parens] [2] ERROR: Source/WebCore/rendering/RenderElement.cpp:2074: Extra space after ( [whitespace/parens] [2] ERROR: Source/WebCore/rendering/RenderElement.cpp:2075: Extra space after ( [whitespace/parens] [2] ERROR: Source/WebCore/rendering/RenderElement.cpp:2078: Extra space after ( [whitespace/parens] [2] ERROR: Source/WebCore/rendering/RenderElement.cpp:2079: Extra space after ( [whitespace/parens] [2] Total errors found: 8 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.

Simon Fraser (smfr)

Comment 5 2016-01-16 09:16:00 PST

Created attachment 269173 [details] Patch

WebKit Commit Bot

Comment 6 2016-01-16 09:18:06 PST

Attachment 269173 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/RenderElement.cpp:2061: Extra space after ( [whitespace/parens] [2] ERROR: Source/WebCore/rendering/RenderElement.cpp:2062: Extra space after ( [whitespace/parens] [2] ERROR: Source/WebCore/rendering/RenderElement.cpp:2066: Extra space after ( [whitespace/parens] [2] ERROR: Source/WebCore/rendering/RenderElement.cpp:2069: Extra space after ( [whitespace/parens] [2] ERROR: Source/WebCore/rendering/RenderElement.cpp:2074: Extra space after ( [whitespace/parens] [2] ERROR: Source/WebCore/rendering/RenderElement.cpp:2075: Extra space after ( [whitespace/parens] [2] ERROR: Source/WebCore/rendering/RenderElement.cpp:2078: Extra space after ( [whitespace/parens] [2] ERROR: Source/WebCore/rendering/RenderElement.cpp:2079: Extra space after ( [whitespace/parens] [2] Total errors found: 8 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.

Sam Weinig

Comment 7 2016-01-16 18:33:48 PST

Comment on attachment 269173 [details] Patch Nice simplification!

Simon Fraser (smfr)

Comment 8 2016-01-20 21:19:36 PST

http://trac.webkit.org/changeset/195170

Note You need to log in before you can comment on or make changes to this bug.