Bug 153169

Summary: Give RuleSet a BumpArena and start using it for RuleDataVectors.
Product: WebKit Reporter: Andreas Kling <kling>
Component: CSSAssignee: Andreas Kling <kling>
Status: REOPENED    
Severity: Normal CC: cdumez, commit-queue, dewei_zhu, koivisto
Priority: P2 Keywords: Performance
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Andreas Kling
Reported 2016-01-15 18:11:00 PST
RuleSet only needs to support append operations, so it's a great candidate for BumpArena optimizations.
Attachments
Patch (4.43 KB, patch)
2016-01-15 18:12 PST, Andreas Kling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2016-01-15 18:12:14 PST
Created attachment 269135 [details] Patch
Antti Koivisto
Comment 2 2016-01-16 11:46:14 PST
r=me
WebKit Commit Bot
Comment 3 2016-01-16 12:37:38 PST
Comment on attachment 269135 [details] Patch Clearing flags on attachment: 269135 Committed r195173: <http://trac.webkit.org/changeset/195173>
WebKit Commit Bot
Comment 4 2016-01-16 12:37:42 PST
All reviewed patches have been landed. Closing bug.
Chris Dumez
Comment 5 2016-01-19 13:00:07 PST
Reverted r195173 for reason: It relies on r195141 which was rolled out Committed r195309: <http://trac.webkit.org/changeset/195309>
dewei_zhu
Comment 6 2016-01-19 15:52:26 PST
This change will crash JetStream on "bigfib.cpp".
Note You need to log in before you can comment on or make changes to this bug.