Bug 153166

Summary: CSP: Update violation report 'Content-Type' header
Product: WebKit Reporter: Daniel Bates <dbates>
Component: WebCore Misc.Assignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cdumez, commit-queue, esprehn+autocc, gyuyoung.kim, japhet, mkwst, webkit-bug-importer
Priority: P2 Keywords: BlinkMergeCandidate, InRadar
Version: WebKit Local Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=154288
https://bugs.webkit.org/show_bug.cgi?id=153242
Attachments:
Description Flags
Patch
none
Patch
bfulgham: review+, buildbot: commit-queue-
Archive of layout-test-results from ews112 for mac-yosemite none

Description Daniel Bates 2016-01-15 17:40:24 PST 
We should merge <https://src.chromium.org/viewvc/blink?view=rev&revision=154215>.

CSP: Update violation report 'Content-Type' header.

The spec recently changed the type of violation reports from
'application/json' to 'application/csp-report'[1]. This patch implements
that change by adding a type flag to the relevant PingLoader method.

[1]: https://dvcs.w3.org/hg/content-security-policy/rev/9c1ebbb88a76
Comment 1 Radar WebKit Bug Importer 2016-01-27 20:55:20 PST 
<rdar://problem/24383327>
Comment 2 Daniel Bates 2016-02-16 12:15:52 PST 
Created attachment 271464 [details]
Patch
Comment 3 Brent Fulgham 2016-02-16 12:18:25 PST 
I don't think we should review this large(ish) patch if it won't apply to trunk. Can you please figure out why this is failing and upload a new patch?
Comment 4 Brent Fulgham 2016-02-16 12:18:46 PST 
Comment on attachment 271464 [details]
Patch

Rejecting because the patch will not apply on EWS, and we can't confirm it builds properly.
Comment 5 Daniel Bates 2016-02-16 13:22:14 PST 
Created attachment 271476 [details]
Patch

Rebased patch following the landing of <http://trac.webkit.org/changeset/196655> and <http://trac.webkit.org/changeset/196653>.
Comment 6 Brent Fulgham 2016-02-16 14:16:48 PST 
Comment on attachment 271476 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=271476&action=review

r=me

> Source/WebCore/loader/PingLoader.cpp:135
> +    request.setHTTPMethod(ASCIILiteral("POST"));

I've always wondered how much benefit we get from using ASCIILiteral. It seems like our String classes should be smart enough to do this automatically (but of course, that's not your issue to worry about!)
Comment 7 Build Bot 2016-02-16 15:13:52 PST 
Comment on attachment 271476 [details]
Patch

Attachment 271476 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/841967

New failing tests:
js/regress/Float64Array-to-Int16Array-set.html
js/regress/Float32Array-to-Float64Array-set.html
Comment 8 Build Bot 2016-02-16 15:13:56 PST 
Created attachment 271492 [details]
Archive of layout-test-results from ews112 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 9 Daniel Bates 2016-02-16 15:22:20 PST 
Committed r196664: <http://trac.webkit.org/changeset/196664>